don't special case DefKind::Ctor in encoding
#94252
Merged
+46
−51
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rustbot
added
the
T-compiler
rust-highfive
added
the
S-waiting-on-review
|
☔ The latest upstream changes (presumably #94129) made this pull request unmergeable. Please resolve the merge conflicts. |
This comment has been minimized.
This comment has been minimized.
lcnr
force-pushed
the
def_kind-encoding
branch
from
a1fd42e to
ae45e8a
Compare
|
I had originally introduced this to avoid a change in diagnostics. It don't expect any other consequence. |
|
📌 Commit ae45e8a has been approved by |
bors
added
S-waiting-on-bors
|
⌛ Testing commit ae45e8a with merge cc14ae0823a1dd79fe26dd4a41f586d8c664894d... |
|
💔 Test failed - checks-actions |
bors
added
S-waiting-on-review
|
crates.io was down ^^ @bors retry |
bors
added
S-waiting-on-bors
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Feb 25, 2022
…askrgr Rollup of 7 pull requests Successful merges: - rust-lang#93845 (Remove in band lifetimes) - rust-lang#94155 (Extend toggle GUI test a bit) - rust-lang#94252 (don't special case `DefKind::Ctor` in encoding) - rust-lang#94305 (Remove an unnecessary restriction in `dest_prop`) - rust-lang#94343 (Miri fn ptr check: don't use conservative null check) - rust-lang#94344 (diagnostic: suggest parens when users want logical ops, but get closures) - rust-lang#94352 (Fix SGX docs build) Failed merges: r? `@ghost` `@rustbot` modify labels: rollup
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
considering that we still use
DefKind::Ctorfor these inRes, this seems weird and definitely felt like a bug when encountering it while working on #89862.r? @cjgillot