Skip to content

remove feature gate in control_flow examples #94283

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom
Merged
merged 1 commit into from
Feb 24, 2022
Merged

remove feature gate in control_flow examples #94283

merged 1 commit into from
Feb 24, 2022

Conversation

hellow554
Copy link
Contributor

Stabilization was done in #91091, but the two examples weren't updated accordingly.

Probably too late to put it into stable, but it should be in the next release :)

@rust-highfive
Copy link
Contributor

r? @Mark-Simulacrum

(rust-highfive has picked a reviewer for you, use r? to override)

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Feb 23, 2022
@Dylan-DPC
Copy link
Member

r? @Dylan-DPC

@Dylan-DPC
Copy link
Member

@bors r+ rollup

@bors
Copy link
Collaborator

bors commented Feb 23, 2022

📌 Commit c403424 has been approved by Dylan-DPC

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Feb 23, 2022
@matthiaskrgr matthiaskrgr mentioned this pull request Feb 24, 2022
Merged
bors added a commit to rust-lang-ci/rust that referenced this pull request Feb 24, 2022
@bors
Auto merge of rust-lang#94314 - matthiaskrgr:rollup-hmed8n7, r=matthi…
1204400 
…askrgr

Rollup of 9 pull requests

Successful merges:

 - rust-lang#89887 (Change `char` type in debuginfo to DW_ATE_UTF)
 - rust-lang#94267 (Remove unused ordering derivations and bounds for `SimplifiedTypeGen`)
 - rust-lang#94270 (Miri: relax fn ptr check)
 - rust-lang#94273 (add matching doc to errorkind)
 - rust-lang#94283 (remove feature gate in control_flow examples)
 - rust-lang#94288 (Cleanup a few Decoder methods)
 - rust-lang#94292 (riscv32imc_esp_espidf: set max_atomic_width to 64)
 - rust-lang#94296 (:arrow_up: rust-analyzer)
 - rust-lang#94300 (Fix a typo in documentation of `array::IntoIter::new_unchecked`)

Failed merges:

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit f3433d1 into rust-lang:master Feb 24, 2022
@rustbot rustbot added this to the 1.61.0 milestone Feb 24, 2022
@bugadani bugadani mentioned this pull request Feb 25, 2022
Closed
@ehuss ehuss added the beta-nominated Nominated for backporting to the compiler in the beta channel. label Feb 25, 2022
@ehuss
Copy link
Contributor

ehuss commented Feb 25, 2022

Beta nominated to avoid confusion.

@ehuss ehuss added the T-libs Relevant to the library team, which will review and decide on the PR/issue. label Feb 25, 2022
@Mark-Simulacrum
Copy link
Member

CI did not catch this because the feature gate is still unstable -- it's probably not used for these examples, which is why removing it is fine, but I think we don't track libs feature usage at such a level?

@ehuss
Copy link
Contributor

ehuss commented Mar 2, 2022

I'm not sure I understand the comment. The control_flow_enum feature was needed previously. When it was stabilized, it was split off to control_flow_enum_is. However, that's not really important. Doc tests don't deny warnings (they don't show at all), so the stable_features lint has no effect. CI currently doesn't check for things like this.

@Mark-Simulacrum
Copy link
Member

Yeah, @Urgau pointed me to the rustdoc allow list -- that's likely the real issue here.

That said, it does look like there are some unstable remnants too still under control_flow_enum (

rust/library/core/src/ops/control_flow.rs

Line 177 in 08504c6

#[unstable(feature = "control_flow_enum", reason = "new API", issue = "75744")]
).

@Mark-Simulacrum Mark-Simulacrum added the beta-accepted Accepted for backporting to the compiler in the beta channel. label Mar 9, 2022
@Mark-Simulacrum
Copy link
Member

Discussed briefly in an ad-hoc libs meeting (with very partial attendance), but in any case, seems like a reasonable backport. Approving.

@Mark-Simulacrum Mark-Simulacrum modified the milestones: 1.61.0, 1.60.0 Mar 14, 2022
@Mark-Simulacrum Mark-Simulacrum removed the beta-nominated Nominated for backporting to the compiler in the beta channel. label Mar 14, 2022
@Mark-Simulacrum Mark-Simulacrum mentioned this pull request Mar 14, 2022
Merged
bors added a commit to rust-lang-ci/rust that referenced this pull request Mar 14, 2022
@bors
Auto merge of rust-lang#94933 - Mark-Simulacrum:beta-next, r=Mark-Sim…
99f967e 
…ulacrum

[beta] backports

* Update LLVM submodule rust-lang#94764
* Statically compile libstdc++ everywhere if asked rust-lang#94719
* Downgrade #[test] on macro call to warning rust-lang#94624
* Delay bug in expr adjustment when check_expr is called multiple times rust-lang#94596
* bootstrap: correct reading of flags for llvm rust-lang#94466
* Check method input expressions once rust-lang#94438
* remove feature gate in control_flow examples rust-lang#94283

r? `@Mark-Simulacrum`
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers
No reviews
Assignees

@Dylan-DPC Dylan-DPC

Labels
beta-accepted Accepted for backporting to the compiler in the beta channel. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-libs Relevant to the library team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
1.60.0
Development

Successfully merging this pull request may close these issues.
7 participants
@hellow554 @rust-highfive @Dylan-DPC @bors @ehuss @Mark-Simulacrum @rustbot