Skip to content

update auto trait lint for PhantomData #94315

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom
Merged
merged 1 commit into from
Feb 25, 2022
Merged

update auto trait lint for PhantomData #94315

merged 1 commit into from
Feb 25, 2022

Conversation

lcnr
Copy link
Contributor

@lcnr lcnr commented Feb 24, 2022 •
edited
Loading

@lcnr lcnr added the A-auto-traits Area: auto traits (e.g., `auto trait Send {}`) label Feb 24, 2022
@rustbot rustbot added the T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. label Feb 24, 2022
@rust-highfive
Copy link
Contributor

r? @oli-obk

(rust-highfive has picked a reviewer for you, use r? to override)

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Feb 24, 2022
@lcnr lcnr added the beta-nominated Nominated for backporting to the compiler in the beta channel. label Feb 24, 2022
@lcnr
Copy link
Contributor Author

lcnr commented Feb 24, 2022 •
edited
Loading

this is a really small change and prevents a new lint from firing incorrectly in more places, so it would be good to release the lint together with this change.

@oli-obk
Copy link
Contributor

oli-obk commented Feb 24, 2022

@bors r+ rollup

@bors
Copy link
Collaborator

bors commented Feb 24, 2022

📌 Commit 70018c1 has been approved by oli-obk

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Feb 24, 2022
@apiraino
Copy link
Contributor

Beta backport accepted as per compiler team on Zulip

@rustbot label +beta-accepted

@rustbot rustbot added the beta-accepted Accepted for backporting to the compiler in the beta channel. label Feb 24, 2022
Manishearth added a commit to Manishearth/rust that referenced this pull request Feb 24, 2022
@Manishearth
Rollup merge of rust-lang#94315 - lcnr:auto-trait-lint-update, r=oli-obk
2c801e8 
update auto trait lint for `PhantomData`

cc rust-lang#93367 (comment)
@Manishearth Manishearth mentioned this pull request Feb 24, 2022
Closed
Dylan-DPC added a commit to Dylan-DPC/rust that referenced this pull request Feb 24, 2022
@Dylan-DPC
Rollup merge of rust-lang#94315 - lcnr:auto-trait-lint-update, r=oli-obk
d4db2be 
update auto trait lint for `PhantomData`

cc rust-lang#93367 (comment)
@Dylan-DPC Dylan-DPC mentioned this pull request Feb 24, 2022
Closed
Dylan-DPC added a commit to Dylan-DPC/rust that referenced this pull request Feb 24, 2022
@Dylan-DPC
Rollup merge of rust-lang#94315 - lcnr:auto-trait-lint-update, r=oli-obk
dd2c56e 
update auto trait lint for `PhantomData`

cc rust-lang#93367 (comment)
This was referenced Feb 24, 2022
Closed
Merged
bors added a commit to rust-lang-ci/rust that referenced this pull request Feb 24, 2022
@bors
Auto merge of rust-lang#94333 - Dylan-DPC:rollup-7yxtywp, r=Dylan-DPC
4e82f35 
Rollup of 9 pull requests

Successful merges:

 - rust-lang#91795 (resolve/metadata: Stop encoding macros as reexports)
 - rust-lang#93714 (better ObligationCause for normalization errors in `can_type_implement_copy`)
 - rust-lang#94175 (Improve `--check-cfg` implementation)
 - rust-lang#94212 (Stop manually SIMDing in `swap_nonoverlapping`)
 - rust-lang#94242 (properly handle fat pointers to uninhabitable types)
 - rust-lang#94308 (Normalize main return type during mono item collection & codegen)
 - rust-lang#94315 (update auto trait lint for `PhantomData`)
 - rust-lang#94316 (Improve string literal unescaping)
 - rust-lang#94327 (Avoid emitting full macro body into JSON errors)

Failed merges:

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit 9e7131a into rust-lang:master Feb 25, 2022
@rustbot rustbot added this to the 1.61.0 milestone Feb 25, 2022
@lcnr lcnr deleted the auto-trait-lint-update branch February 25, 2022 09:08
ehuss pushed a commit to ehuss/rust that referenced this pull request Mar 3, 2022
@Dylan-DPC @ehuss
Rollup merge of rust-lang#94315 - lcnr:auto-trait-lint-update, r=oli-obk
150cc0c 
update auto trait lint for `PhantomData`

cc rust-lang#93367 (comment)
@ehuss ehuss mentioned this pull request Mar 3, 2022
Merged
@ehuss ehuss modified the milestones: 1.61.0, 1.60.0 Mar 3, 2022
@ehuss ehuss removed the beta-nominated Nominated for backporting to the compiler in the beta channel. label Mar 3, 2022
bors added a commit to rust-lang-ci/rust that referenced this pull request Mar 3, 2022
@bors
Auto merge of rust-lang#94545 - ehuss:beta-backports, r=ehuss
c1d075a 
[beta] Beta backports

* No branch protection metadata unless enabled rust-lang#93516
* update auto trait lint for PhantomData rust-lang#94315
* Cargo:
    * [1.60] Fix term.verbose without quiet, and vice versa (rust-lang/cargo#10436)
    * [beta] Add common profile validation. (rust-lang/cargo#10413)
    * Avoid new deprecation warnings from clap 3.1.0 (rust-lang/cargo#10396)
@lcnr lcnr mentioned this pull request Mar 14, 2022
Merged
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers
No reviews
Assignees

@oli-obk oli-obk

Labels
A-auto-traits Area: auto traits (e.g., `auto trait Send {}`) beta-accepted Accepted for backporting to the compiler in the beta channel. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
1.60.0
Development

Successfully merging this pull request may close these issues.
7 participants
@lcnr @rust-highfive @oli-obk @bors @apiraino @ehuss @rustbot