Skip to content

Fix duplicated impl links #94417

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom
Merged
merged 2 commits into from
Feb 28, 2022
Merged

Fix duplicated impl links #94417

merged 2 commits into from
Feb 28, 2022

Conversation

GuillaumeGomez
Copy link
Member

@GuillaumeGomez GuillaumeGomez commented Feb 27, 2022 •
edited
Loading

Fixes #78701.

The problem is that the blanket impl has the same ID as the other impl, except that we don't derive IDs when we generate the sidebar. We now do.

r? @notriddle

@GuillaumeGomez GuillaumeGomez added the T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue. label Feb 27, 2022
@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Feb 27, 2022
@rust-log-analyzer
Copy link
Collaborator

The job x86_64-gnu-tools failed! Check out the build log: (web) (plain)

Click to see the possible cause of the failure (guessed by this bot) 
  IMAGE: x86_64-gnu-tools
##[endgroup]
From https://github.com/rust-lang/rust
 * branch              master     -> FETCH_HEAD
Searching for toolstate changes between 93230281562cd6b1b45eff070c473e3be20d9e72 and 426ea0cd5b848232a55bbd9fef4343807dab597c
Rustdoc was updated
##[group]Run src/ci/scripts/verify-channel.sh
src/ci/scripts/verify-channel.sh
shell: /usr/bin/bash --noprofile --norc -e -o pipefail {0}
env:
---
................... (50/60)
.......... (60/60)


/checkout/src/test/rustdoc-gui/toggle-click-deadspace.goml An exception occured: Failed to launch the browser process!
Inconsistency detected by ld.so: dl-tls.c: 493: _dl_allocate_tls_init: Assertion `listp->slotinfo[cnt].gen <= GL(dl_tls_generation)' failed!


TROUBLESHOOTING: https://github.com/puppeteer/puppeteer/blob/master/docs/troubleshooting.md
== STACKTRACE ==
Error
Error
    at innerRunTestCode (/node-v14.4.0-linux-x64/lib/node_modules/browser-ui-test/src/index.js:468:16)
    at runMicrotasks (<anonymous>)
    at processTicksAndRejections (internal/process/task_queues.js:97:5)

@GuillaumeGomez
Copy link
Member Author

Spurious failure. I'll really need to try to prevent it somehow...

@notriddle
Copy link
Contributor

@bors r+

@bors
Copy link
Collaborator

bors commented Feb 27, 2022

📌 Commit 9b8a6b9 has been approved by notriddle

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Feb 27, 2022
matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull request Feb 27, 2022
@matthiaskrgr
Rollup merge of rust-lang#94417 - GuillaumeGomez:fix-duplicated-impl-…
178df4e 
…links, r=notriddle

Fix duplicated impl links

Fixes rust-lang#78701.

The problem is that the blanket impl has the same ID as the other impl, except that we don't derive IDs when we generate the sidebar. We now do.

r? `@notriddle`
@matthiaskrgr matthiaskrgr mentioned this pull request Feb 27, 2022
Closed
@matthiaskrgr matthiaskrgr mentioned this pull request Feb 27, 2022
Merged
bors added a commit to rust-lang-ci/rust that referenced this pull request Feb 28, 2022
@bors
Auto merge of rust-lang#94431 - matthiaskrgr:rollup-1jsj0wu, r=matthi…
b07d59f 
…askrgr

Rollup of 7 pull requests

Successful merges:

 - rust-lang#94396 (1 - Make more use of `let_chains`)
 - rust-lang#94397 (Document that pre-expansion lint passes are softly deprecated)
 - rust-lang#94399 (Add test for rust-lang#79465 to prevent regression)
 - rust-lang#94409 (avoid rebuilding bootstrap when PATH changes)
 - rust-lang#94415 (Use the first codegen backend in the config.toml as default)
 - rust-lang#94417 (Fix duplicated impl links)
 - rust-lang#94420 (3 - Make more use of `let_chains`)

Failed merges:

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit 04ecf52 into rust-lang:master Feb 28, 2022
@rustbot rustbot added this to the 1.61.0 milestone Feb 28, 2022
@GuillaumeGomez GuillaumeGomez mentioned this pull request Mar 7, 2022
Open
@GuillaumeGomez GuillaumeGomez deleted the fix-duplicated-impl-links branch August 19, 2024 12:22
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@notriddle notriddle notriddle approved these changes

Assignees

@notriddle notriddle

Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
1.61.0
Development

Successfully merging this pull request may close these issues.

rustdoc links to non-blanket impl for blanket impl in sidebar
6 participants
@GuillaumeGomez @rust-log-analyzer @notriddle @bors @rust-highfive @rustbot