Skip to content

Add some examples to comments in mbe code #94544

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Merged
merged 1 commit into from
Mar 3, 2022

Conversation

mark-i-m
Copy link
Member

@mark-i-m mark-i-m commented Mar 3, 2022

I found these things non-obvious when re-familiarizing myself with the code.

r? @petrochenkov

@rustbot rustbot added the T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. label Mar 3, 2022
@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Mar 3, 2022
@petrochenkov
Copy link
Contributor

@bors r+ rollup

@bors
Copy link
Collaborator

bors commented Mar 3, 2022

📌 Commit 88b9922 has been approved by petrochenkov

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Mar 3, 2022
bors added a commit to rust-lang-ci/rust that referenced this pull request Mar 3, 2022
…askrgr

Rollup of 8 pull requests

Successful merges:

 - rust-lang#93562 (Update the documentation for `{As,Into,From}Raw{Fd,Handle,Socket}`.)
 - rust-lang#94101 (rustdoc: add test cases for hidden enum variants)
 - rust-lang#94484 (8 - Make more use of `let_chains`)
 - rust-lang#94522 (Remove out-of-context line at end of E0284 message)
 - rust-lang#94534 (Re-export (unstable) core::ffi types from std::ffi)
 - rust-lang#94536 (Move transmute_undefined_repr back to nursery again)
 - rust-lang#94537 (Use ? operator in one instance instead of manual match)
 - rust-lang#94544 (Add some examples to comments in mbe code)

Failed merges:

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit 88aa75b into rust-lang:master Mar 3, 2022
@rustbot rustbot added this to the 1.61.0 milestone Mar 3, 2022
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants