Skip to content

add tests for #94502 #94553

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 7, 2022
Merged

add tests for #94502 #94553

merged 1 commit into from
Mar 7, 2022

Conversation

lcnr
Copy link
Contributor

@lcnr lcnr commented Mar 3, 2022

cc #94552

@rustbot rustbot added the T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. label Mar 3, 2022
@rust-highfive
Copy link
Contributor

r? @Mark-Simulacrum

(rust-highfive has picked a reviewer for you, use r? to override)

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Mar 3, 2022
@lcnr lcnr mentioned this pull request Mar 3, 2022
Merged
@Dylan-DPC
Copy link
Member

@bors r+ rollup

@bors
Copy link
Collaborator

bors commented Mar 3, 2022

📌 Commit 188ae00 has been approved by Dylan-DPC

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Mar 3, 2022
matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull request Mar 3, 2022
@matthiaskrgr
Rollup merge of rust-lang#94553 - lcnr:add-tests, r=Dylan-DPC
aaac4f9 
add tests for rust-lang#94502

cc rust-lang#94552
@matthiaskrgr matthiaskrgr mentioned this pull request Mar 3, 2022
Closed
@matthiaskrgr
Copy link
Member

@bors r-
looks like this failed in a rollup, not sure why it didn't fail in pre-merge ci though, hmm 🤔
#94567 (comment)

@bors bors added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Mar 3, 2022
matthiaskrgr
matthiaskrgr reviewed Mar 3, 2022
View reviewed changes
src/test/ui/nll/lint-no-err.rs
@@ -0,0 +1,23 @@
// check-pass
Copy link
Member

@matthiaskrgr matthiaskrgr Mar 3, 2022 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oh is it because of check-pass?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

but i don't see why it wouldn't be picked by the CI then

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this borrowcheck warning is a hard error with nll enabled, we don't test nll in ci

@lcnr
Copy link
Contributor Author

lcnr commented Mar 7, 2022

@bors r=Dylan-DPC rollup

@bors
Copy link
Collaborator

bors commented Mar 7, 2022

📌 Commit dad81b6 has been approved by Dylan-DPC

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Mar 7, 2022
@matthiaskrgr matthiaskrgr mentioned this pull request Mar 7, 2022
Merged
bors added a commit to rust-lang-ci/rust that referenced this pull request Mar 7, 2022
@bors
Auto merge of rust-lang#94695 - matthiaskrgr:rollup-5pi3acz, r=matthi…
d137c3a 
…askrgr

Rollup of 4 pull requests

Successful merges:

 - rust-lang#94553 (add tests for rust-lang#94502)
 - rust-lang#94614 (Remove ordering traits from `rustc_span::hygiene::LocalExpnId`)
 - rust-lang#94685 (interpret: move saturating_add/sub into (pub) helper method)
 - rust-lang#94688 (Erase regions when checking for missing Copy predicates)

Failed merges:

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit 2c98eda into rust-lang:master Mar 7, 2022
@rustbot rustbot added this to the 1.61.0 milestone Mar 7, 2022
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@matthiaskrgr matthiaskrgr matthiaskrgr left review comments

@Dylan-DPC Dylan-DPC Dylan-DPC left review comments

Assignees

@Mark-Simulacrum Mark-Simulacrum

Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
1.61.0
Development

Successfully merging this pull request may close these issues.
7 participants
@lcnr @rust-highfive @Dylan-DPC @bors @matthiaskrgr @Mark-Simulacrum @rustbot