-
Notifications
You must be signed in to change notification settings - Fork 13.4k
Edit docs on consistency of PartialOrd
and PartialEq
#94620
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
Conversation
Use ordered list to make the information about implementations more readable.
r? @yaahc (rust-highfive has picked a reviewer for you, use r? to override) |
Just a style suggestion. Feel free to close if it doesn't feel like an improvement. :) |
I think its a welcome improvement and significantly reduces how noisy it looks without reducing the amount of information being communicated. Thank you! @bors r+ rollup |
📌 Commit f0257b1 has been approved by |
Personally i like the idea but i feel it could be more confusing as people need to look up the numbers after reading the comment so i'm not sure there's much gain in this. |
noted. cc @rust-lang/libs-api to see if anyone else has strong feelings for or against this change. |
…=yaahc Edit docs on consistency of `PartialOrd` and `PartialEq` Use ordered list to make the information about implementations more readable.
Rollup of 6 pull requests Successful merges: - rust-lang#94446 (UNIX `remove_dir_all()`: Try recursing first on the slow path) - rust-lang#94460 (Reenable generator drop tracking tests and fix mutation handling) - rust-lang#94620 (Edit docs on consistency of `PartialOrd` and `PartialEq`) - rust-lang#94624 (Downgrade `#[test]` on macro call to warning) - rust-lang#94626 (Add known-bug directive to issue rust-lang#47511 test case) - rust-lang#94631 (Fix typo in c-variadic) Failed merges: r? `@ghost` `@rustbot` modify labels: rollup
Use ordered list to make the information about implementations more readable.