Skip to content

do not attempt to open cgroup files under Miri #94645

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Merged
merged 1 commit into from
Mar 5, 2022

Conversation

RalfJung
Copy link
Member

@RalfJung RalfJung commented Mar 5, 2022

Since #92697, cargo miri test always fails under default flags, and one would have to use MIRIFLAGS=-Zmiri-disable-isolation cargo miri test instead. This PR fixes that problem.

Cc @the8472 @joshtriplett

@rust-highfive
Copy link
Contributor

r? @joshtriplett

(rust-highfive has picked a reviewer for you, use r? to override)

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Mar 5, 2022
@RalfJung RalfJung mentioned this pull request Mar 5, 2022
@the8472
Copy link
Member

the8472 commented Mar 5, 2022

@bors r+

@bors
Copy link
Collaborator

bors commented Mar 5, 2022

📌 Commit 51b4ea2 has been approved by the8472

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Mar 5, 2022
@RalfJung
Copy link
Member Author

RalfJung commented Mar 5, 2022

@bors rollup=always

bors added a commit to rust-lang-ci/rust that referenced this pull request Mar 5, 2022
Rollup of 4 pull requests

Successful merges:

 - rust-lang#94630 (Update note about tier 2 docs.)
 - rust-lang#94633 (Suggest removing a semicolon after derive attributes)
 - rust-lang#94642 (Fix source code pages scroll)
 - rust-lang#94645 (do not attempt to open cgroup files under Miri)

Failed merges:

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit 00fd87e into rust-lang:master Mar 5, 2022
@rustbot rustbot added this to the 1.61.0 milestone Mar 5, 2022
@RalfJung RalfJung deleted the available-parallelism-miri branch March 6, 2022 00:23
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants