Unix path::absolute: Fix leading "." component #94649
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Testing leading `.` and `..` components were missing from the unix tests.
|
(rust-highfive has picked a reviewer for you, use r? to override) |
rust-highfive
added
the
S-waiting-on-review
ChrisDenton
changed the title
|
r? @Dylan-DPC |
|
@bors r+ rollup |
|
📌 Commit 0421af9 has been approved by |
bors
added
S-waiting-on-bors
matthiaskrgr
added a commit
to matthiaskrgr/rust
that referenced
this pull request
Mar 6, 2022
…lan-DPC Unix path::absolute: Fix leading "." component Testing leading `.` and `..` components were missing from the unix tests. This PR adds them and fixes the leading `.` case. It also fixes the test cases so that they do an exact comparison. This problem reported by `@axetroy`
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Mar 6, 2022
Rollup of 3 pull requests Successful merges: - rust-lang#92509 (doc: `Iterator::partition` use partial type hints) - rust-lang#94621 (rustbuild: support RelWithDebInfo for lld) - rust-lang#94649 (Unix path::absolute: Fix leading "." component) Failed merges: r? `@ghost` `@rustbot` modify labels: rollup
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Testing leading
.and..components were missing from the unix tests.This PR adds them and fixes the leading
.case. It also fixes the test cases so that they do an exact comparison.This problem reported by @axetroy