Rollup of 7 pull requests #94760

Dylan-DPC · 2022-03-09T04:34:12Z

Successful merges:

Edit rustc_trait_selection::infer::lattice docs #94312 (Edit rustc_trait_selection::infer::lattice docs)
Add a team for '@rustbot ping fuchsia' #94583 (Add a team for '@rustbot ping fuchsia')
Do not allow #[rustc_legacy_const_generics] on methods #94686 (Do not allow #[rustc_legacy_const_generics] on methods)
BTree: remove dead data needlessly complicating insert #94699 (BTree: remove dead data needlessly complicating insert)
diagnostics: use rustc_on_unimplemented to recommend [].iter() #94746 (diagnostics: use rustc_on_unimplemented to recommend [].iter())
Use unreachable! for an unreachable code path #94756 (Use unreachable! for an unreachable code path)
Update cargo #94759 (Update cargo)

Failed merges:

r? @ghost
@rustbot modify labels: rollup

Remove mentions of outdated/missing type and filename (`infer.rs` and `LatticeValue`).

It caused an ICE since `item` was `None`.

To make this work, the `#[rustc_on_unimplemented]` data needs to be used to report method resolution errors, which is most of what this commit does. Fixes rust-lang#94581

…jackh726 Edit `rustc_trait_selection::infer::lattice` docs Closes rust-lang#94311. Removes mentions of outdated/missing type and filename (`infer.rs` and `LatticeValue`).

@rustbot

Add a team for '@rustbot ping fuchsia' I was looking for this in response to rust-lang#93858 (comment). Depends on rust-lang/team#710.

…h726 Do not allow `#[rustc_legacy_const_generics]` on methods It caused an ICE since `item` was `None`. Fixes rust-lang#94629.

…-DPC BTree: remove dead data needlessly complicating insert Possibly needless instructions generated r? rust-lang/libs r? `@Amanieu` cc `@frank-king`

…-unimplemented, r=davidtwco diagnostics: use rustc_on_unimplemented to recommend `[].iter()` To make this work, the `#[rustc_on_unimplemented]` data needs to be used to report method resolution errors, which is most of what this commit does. Fixes rust-lang#94581

Use `unreachable!` for an unreachable code path Closes rust-lang#73212

Update cargo 11 commits in 3d6970d50e30e797b8e26b2b9b1bdf92dc381f34..65c82664263feddc5fe2d424be0993c28d46377a 2022-02-28 19:29:07 +0000 to 2022-03-09 02:32:56 +0000 - Remove remaining 2 warn(clippy::*) instances (rust-lang/cargo#10438) - Use `available_parallelism` instead of `num_cpus` (rust-lang/cargo#10427) - Wait up to one second while waiting for curl (rust-lang/cargo#10456) - Improve code coverage (rust-lang/cargo#10460) - Don't recommend leaking tokens into the console history (rust-lang/cargo#10458) - fix some typos (rust-lang/cargo#10454) - Use `extend` instead of `push`ing in a loop (rust-lang/cargo#10453) - Use locked_version more (rust-lang/cargo#10449) - Disable dependabot (rust-lang/cargo#10443) - Update git2 dependencies (rust-lang/cargo#10442) - Stop gating stable features (rust-lang/cargo#10434)

rustbot · 2022-03-09T04:34:16Z

Error: Parsing ping command in comment failed: ...'g fuchsia'' | error: expected end of command at >| ')

Lex nested block comments #9468'...

Please let @rust-lang/release know if you're having trouble with this bot.

Dylan-DPC · 2022-03-09T04:34:42Z

@bors r+ rollup=never p=5

bors · 2022-03-09T04:34:43Z

📌 Commit ab7c6d6 has been approved by Dylan-DPC

bors · 2022-03-09T05:01:16Z

⌛ Testing commit ab7c6d6 with merge 6e8268525ef8f01f64179372735df240b2059943...

rust-log-analyzer · 2022-03-09T05:20:14Z

The job dist-i586-gnu-i586-i686-musl failed! Check out the build log: (web) (plain)

Click to see the possible cause of the failure (guessed by this bot)


---- [ui] ui/issues/issue-31173.rs stdout ----
diff of stderr:

13    |                                ^^^^^^^^^^^^ required by this bound in `cloned`
14 
15 error[E0599]: the method `collect` exists for struct `Cloned<TakeWhile<&mut std::vec::IntoIter<u8>, [closure@$DIR/issue-31173.rs:6:39: 9:6]>>`, but its trait bounds were not satisfied
-   --> $DIR/issue-31173.rs:12:10
17    |
- LL |         .collect();
-    |          ^^^^^^^ method cannot be called on `Cloned<TakeWhile<&mut std::vec::IntoIter<u8>, [closure@$DIR/issue-31173.rs:6:39: 9:6]>>` due to unsatisfied trait bounds
+   ::: $SRC_DIR/core/src/iter/adapters/cloned.rs:LL:COL
20    |
+ LL | pub struct Cloned<I> {
+    | -------------------- doesn't satisfy `_: Iterator`
21   ::: $SRC_DIR/core/src/iter/adapters/take_while.rs:LL:COL
22    |
22    |
23 LL | pub struct TakeWhile<I, P> {

24    | -------------------------- doesn't satisfy `<_ as Iterator>::Item = &_`
25    |
-   ::: $SRC_DIR/core/src/iter/adapters/cloned.rs:LL:COL
-    |
-    |
- LL | pub struct Cloned<I> {
-    | -------------------- doesn't satisfy `_: Iterator`
+ LL |         .collect();
+    |          ^^^^^^^ method cannot be called on `Cloned<TakeWhile<&mut std::vec::IntoIter<u8>, [closure@$DIR/issue-31173.rs:6:39: 9:6]>>` due to unsatisfied trait bounds
Some tests failed in compiletest suite=ui mode=ui host=x86_64-unknown-linux-gnu target=i586-unknown-linux-gnu
31    = note: the following trait bounds were not satisfied:
31    = note: the following trait bounds were not satisfied:
32            `<TakeWhile<&mut std::vec::IntoIter<u8>, [closure@$DIR/issue-31173.rs:6:39: 9:6]> as Iterator>::Item = &_`

The actual stderr differed from the expected stderr.
Actual stderr saved to /checkout/obj/build/x86_64-unknown-linux-gnu/test/ui/issues/issue-31173/issue-31173.stderr
To update references, rerun the tests and pass the `--bless` flag
To update references, rerun the tests and pass the `--bless` flag
To only update this specific test, also pass `--test-args issues/issue-31173.rs`

error: 1 errors occurred comparing output.
status: exit status: 1
command: "/checkout/obj/build/x86_64-unknown-linux-gnu/stage2/bin/rustc" "/checkout/src/test/ui/issues/issue-31173.rs" "-Zthreads=1" "--target=i586-unknown-linux-gnu" "--error-format" "json" "--json" "future-incompat" "-Ccodegen-units=1" "-Zui-testing" "-Zdeduplicate-diagnostics=no" "--emit" "metadata" "-C" "prefer-dynamic" "--out-dir" "/checkout/obj/build/x86_64-unknown-linux-gnu/test/ui/issues/issue-31173" "-A" "unused" "-Crpath" "-O" "-Cdebuginfo=0" "-Lnative=/checkout/obj/build/i586-unknown-linux-gnu/native/rust-test-helpers" "-Clinker=cc" "-L" "/checkout/obj/build/x86_64-unknown-linux-gnu/test/ui/issues/issue-31173/auxiliary"
stdout: none
--- stderr -------------------------------
error[E0271]: type mismatch resolving `<TakeWhile<&mut std::vec::IntoIter<u8>, [closure@/checkout/src/test/ui/issues/issue-31173.rs:6:39: 9:6]> as Iterator>::Item == &_`
   |
LL |         .cloned()
   |          ^^^^^^ expected reference, found `u8`
   |
   |
   = note: expected reference `&_`
                   found type `u8`
note: required by a bound in `cloned`
  --> /checkout/library/core/src/iter/traits/iterator.rs:3140:32
   |
LL |         Self: Sized + Iterator<Item = &'a T>,
   |                                ^^^^^^^^^^^^ required by this bound in `cloned`

error[E0599]: the method `collect` exists for struct `Cloned<TakeWhile<&mut std::vec::IntoIter<u8>, [closure@/checkout/src/test/ui/issues/issue-31173.rs:6:39: 9:6]>>`, but its trait bounds were not satisfied
  ::: /checkout/library/core/src/iter/adapters/cloned.rs:17:1
   |
   |
LL | pub struct Cloned<I> {
   | -------------------- doesn't satisfy `_: Iterator`
  ::: /checkout/library/core/src/iter/adapters/take_while.rs:15:1
   |
   |
LL | pub struct TakeWhile<I, P> {
   | -------------------------- doesn't satisfy `<_ as Iterator>::Item = &_`
   |
   |
LL |         .collect(); //~ ERROR the method
   |          ^^^^^^^ method cannot be called on `Cloned<TakeWhile<&mut std::vec::IntoIter<u8>, [closure@/checkout/src/test/ui/issues/issue-31173.rs:6:39: 9:6]>>` due to unsatisfied trait bounds
   = note: the following trait bounds were not satisfied:
   = note: the following trait bounds were not satisfied:
           `<TakeWhile<&mut std::vec::IntoIter<u8>, [closure@/checkout/src/test/ui/issues/issue-31173.rs:6:39: 9:6]> as Iterator>::Item = &_`
           which is required by `Cloned<TakeWhile<&mut std::vec::IntoIter<u8>, [closure@/checkout/src/test/ui/issues/issue-31173.rs:6:39: 9:6]>>: Iterator`
           `Cloned<TakeWhile<&mut std::vec::IntoIter<u8>, [closure@/checkout/src/test/ui/issues/issue-31173.rs:6:39: 9:6]>>: Iterator`
           which is required by `&mut Cloned<TakeWhile<&mut std::vec::IntoIter<u8>, [closure@/checkout/src/test/ui/issues/issue-31173.rs:6:39: 9:6]>>: Iterator`
error: aborting due to 2 previous errors

Some errors have detailed explanations: E0271, E0599.
For more information about an error, try `rustc --explain E0271`.

bors · 2022-03-09T05:21:15Z

💔 Test failed - checks-actions

pierwill and others added 14 commits February 28, 2022 16:25

Edit rustc_trait_selection::infer::lattice docs

a014276

Remove mentions of outdated/missing type and filename (`infer.rs` and `LatticeValue`).

Add a team for '@rustbot ping fuchsia'

5b28c38

BTree: remove dead data needlessly complicating insert

36bb53d

Do not allow #[rustc_legacy_const_generics] on methods

96515f4

It caused an ICE since `item` was `None`.

diagnostics: use rustc_on_unimplemented to recommend [].iter()

81e9fad

To make this work, the `#[rustc_on_unimplemented]` data needs to be used to report method resolution errors, which is most of what this commit does. Fixes rust-lang#94581

Use unreachable! for an unreachable code path

57442be

Update cargo

6fee0b0

Rollup merge of rust-lang#94312 - pierwill:fix-94311-lattice-docs, r=…

d6f92cd

…jackh726 Edit `rustc_trait_selection::infer::lattice` docs Closes rust-lang#94311. Removes mentions of outdated/missing type and filename (`infer.rs` and `LatticeValue`).

Rollup merge of rust-lang#94583 - dtolnay:fuchsia, r=Mark-Simulacrum

cc64419

Add a team for '@rustbot ping fuchsia' I was looking for this in response to rust-lang#93858 (comment). Depends on rust-lang/team#710.

Rollup merge of rust-lang#94686 - ChayimFriedman2:issue-94629, r=jack…

f2b9fc2

…h726 Do not allow `#[rustc_legacy_const_generics]` on methods It caused an ICE since `item` was `None`. Fixes rust-lang#94629.

Rollup merge of rust-lang#94699 - ssomers:btree_prune_insert, r=Dylan…

0f880ef

…-DPC BTree: remove dead data needlessly complicating insert Possibly needless instructions generated r? rust-lang/libs r? `@Amanieu` cc `@frank-king`

Rollup merge of rust-lang#94756 - ChrisDenton:unreachable, r=yaahc

560410b

Use `unreachable!` for an unreachable code path Closes rust-lang#73212

rustbot added the T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. label Mar 9, 2022

rustbot added the rollup A PR which is a rollup label Mar 9, 2022

bors added the S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. label Mar 9, 2022

bors added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Mar 9, 2022

Dylan-DPC mentioned this pull request Mar 9, 2022

diagnostics: use rustc_on_unimplemented to recommend [].iter() #94746

Merged

Dylan-DPC closed this Mar 9, 2022

Dylan-DPC deleted the rollup-c6wqbuq branch March 9, 2022 20:25

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Rollup of 7 pull requests #94760

Rollup of 7 pull requests #94760

Uh oh!

Dylan-DPC commented Mar 9, 2022

Uh oh!

rustbot commented Mar 9, 2022

Uh oh!

Dylan-DPC commented Mar 9, 2022

Uh oh!

bors commented Mar 9, 2022

Uh oh!

bors commented Mar 9, 2022

Uh oh!

rust-log-analyzer commented Mar 9, 2022

Uh oh!

bors commented Mar 9, 2022

Uh oh!

Uh oh!

Rollup of 7 pull requests #94760

Rollup of 7 pull requests #94760

Uh oh!

Conversation

Dylan-DPC commented Mar 9, 2022

Uh oh!

rustbot commented Mar 9, 2022

Uh oh!

Dylan-DPC commented Mar 9, 2022

Uh oh!

bors commented Mar 9, 2022

Uh oh!

bors commented Mar 9, 2022

Uh oh!

rust-log-analyzer commented Mar 9, 2022

Uh oh!

bors commented Mar 9, 2022

Uh oh!

Uh oh!