Skip to content

Remove redundant slicing of whole ranges in bootstrap #94863

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Merged
merged 1 commit into from
Mar 12, 2022

Conversation

pierwill
Copy link
Member

Found with clippy::redundant_slicing.

@rust-highfive
Copy link
Contributor

r? @Mark-Simulacrum

(rust-highfive has picked a reviewer for you, use r? to override)

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Mar 11, 2022
@Mark-Simulacrum
Copy link
Member

@bors r+ rollup

I'll approve this, but I don't personally find tiny syntactic cleanups like this to be super helpful myself -- they cause more churn and git blame path extension than help, IMO.

@bors
Copy link
Collaborator

bors commented Mar 11, 2022

📌 Commit df9797b has been approved by Mark-Simulacrum

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Mar 11, 2022
bors added a commit to rust-lang-ci/rust that referenced this pull request Mar 12, 2022
…askrgr

Rollup of 3 pull requests

Successful merges:

 - rust-lang#94150 (rustdoc-json: Include GenericParamDefKind::Type::synthetic in JSON)
 - rust-lang#94833 ([2/2] Implement macro meta-variable expression)
 - rust-lang#94863 (Remove redundant slicing of whole ranges in `bootstrap`)

Failed merges:

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit 49e0137 into rust-lang:master Mar 12, 2022
@rustbot rustbot added this to the 1.61.0 milestone Mar 12, 2022
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants