Skip to content

Fix auto traits in rustdoc #95069

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Merged
merged 2 commits into from
Mar 24, 2022
Merged

Conversation

GuillaumeGomez
Copy link
Member

@rustbot rustbot added T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue. labels Mar 18, 2022
@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Mar 18, 2022
@GuillaumeGomez
Copy link
Member Author

@oli-obk told me they would take a look when they can so assigning it to them.

r? @oli-obk

@rust-highfive rust-highfive assigned oli-obk and unassigned Aaron1011 Mar 18, 2022
@oli-obk
Copy link
Contributor

oli-obk commented Mar 23, 2022

I'm not confident allow_negative_impls needs to exist at all, but this PR doesn't make things worse and it's only used for rustdoc

@bors r+ rollup

@bors
Copy link
Collaborator

bors commented Mar 23, 2022

📌 Commit 7c53ae0 has been approved by oli-obk

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Mar 23, 2022
bors added a commit to rust-lang-ci/rust that referenced this pull request Mar 23, 2022
…askrgr

Rollup of 5 pull requests

Successful merges:

 - rust-lang#94249 (Better errors when a Copy impl on a Struct is not self-consistent)
 - rust-lang#95069 (Fix auto traits in rustdoc)
 - rust-lang#95221 (interpret/memory: simplify check_and_deref_ptr)
 - rust-lang#95225 (remove `[async output]` from `impl Future` pretty-printing)
 - rust-lang#95238 (Stop emitting E0026 for struct enums with underscores)

Failed merges:

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit 0c79c86 into rust-lang:master Mar 24, 2022
@rustbot rustbot added this to the 1.61.0 milestone Mar 24, 2022
@GuillaumeGomez GuillaumeGomez deleted the auto-traits-rustdoc branch March 24, 2022 10:29
bors added a commit to rust-lang-ci/rust that referenced this pull request Mar 28, 2022
… r=oli-obk

Fix perf issue for auto trait selection

Follow-up of rust-lang#95069 which fixes the perf issue introduced by it.

r? `@oli-obk`
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Rustdoc incorrectly shows blanket impls with Send contraints on !Send types
6 participants