Skip to content

Implement stabilization of #[feature(io_safety)]. #95118

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Merged
merged 2 commits into from
Jun 15, 2022

Conversation

sunfishcode
Copy link
Member

Implement stabilization of I/O safety, aka #[feature(io_safety)].

Fixes #87074.

@rust-highfive
Copy link
Contributor

r? @yaahc

(rust-highfive has picked a reviewer for you, use r? to override)

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Mar 19, 2022
@rust-log-analyzer

This comment has been minimized.

@rust-log-analyzer

This comment has been minimized.

@bors

This comment was marked as resolved.

@sunfishcode sunfishcode force-pushed the sunfishcode/stabilize-io-safety branch from 0498007 to 8fe7cca Compare April 12, 2022 15:46
@bors

This comment was marked as resolved.

@sunfishcode sunfishcode force-pushed the sunfishcode/stabilize-io-safety branch from 8fe7cca to 23c7408 Compare April 28, 2022 15:49
@rustbot rustbot added the T-libs Relevant to the library team, which will review and decide on the PR/issue. label Apr 28, 2022
@bors

This comment was marked as resolved.

@bors

This comment was marked as resolved.

@sunfishcode sunfishcode force-pushed the sunfishcode/stabilize-io-safety branch from e3881f4 to f8f557d Compare May 16, 2022 12:08
@sunfishcode sunfishcode marked this pull request as ready for review June 8, 2022 17:04
@joshtriplett
Copy link
Member

@bors r+

@bors
Copy link
Collaborator

bors commented Jun 14, 2022

📌 Commit f8f557de8fcedcbe498fb57d3ffc697070ee1fa7 has been approved by joshtriplett

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jun 14, 2022
@bors
Copy link
Collaborator

bors commented Jun 14, 2022

⌛ Testing commit f8f557de8fcedcbe498fb57d3ffc697070ee1fa7 with merge 0cf727f72fd6b13730839ec56bb0bbef4b7c48f1...

@bors
Copy link
Collaborator

bors commented Jun 14, 2022

💔 Test failed - checks-actions

@bors bors added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Jun 14, 2022
@sunfishcode sunfishcode force-pushed the sunfishcode/stabilize-io-safety branch from f8f557d to 1237232 Compare June 14, 2022 21:50
@rust-log-analyzer

This comment has been minimized.

@sunfishcode
Copy link
Member Author

I missed adding a stable attribute to the WASI try_clone. This is now fixed.

@joshtriplett
Copy link
Member

@bors r+

@bors
Copy link
Collaborator

bors commented Jun 15, 2022

📌 Commit 1237232 has been approved by joshtriplett

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jun 15, 2022
Dylan-DPC added a commit to Dylan-DPC/rust that referenced this pull request Jun 15, 2022
…o-safety, r=joshtriplett

Implement stabilization of `#[feature(io_safety)]`.

Implement stabilization of [I/O safety], aka `#[feature(io_safety)]`.

Fixes rust-lang#87074.

[I/O safety]: https://github.com/rust-lang/rfcs/blob/master/text/3128-io-safety.md
bors added a commit to rust-lang-ci/rust that referenced this pull request Jun 15, 2022
Rollup of 3 pull requests

Successful merges:

 - rust-lang#95118 (Implement stabilization of `#[feature(io_safety)]`.)
 - rust-lang#98110 (Make `ExprKind::Closure` a struct variant.)
 - rust-lang#98115 (Remove `rustc_deprecated` diagnostics)

Failed merges:

r? `@ghost`
`@rustbot` modify labels: rollup
@bors
Copy link
Collaborator

bors commented Jun 15, 2022

⌛ Testing commit 1237232 with merge a4cec97...

@bors bors merged commit 40912e1 into rust-lang:master Jun 15, 2022
@rustbot rustbot added this to the 1.63.0 milestone Jun 15, 2022
@sunfishcode sunfishcode deleted the sunfishcode/stabilize-io-safety branch June 15, 2022 17:18
Thomasdezeeuw added a commit to Thomasdezeeuw/socket2 that referenced this pull request Jul 26, 2022
In the future we'll switch to 1.63 so we can use the I/O safety feature
stabilised in 1.63: rust-lang/rust#95118.
Thomasdezeeuw added a commit to Thomasdezeeuw/socket2 that referenced this pull request Aug 13, 2022
So we can use the I/O safety feature stabilised in 1.63:
rust-lang/rust#95118.
Thomasdezeeuw added a commit to Thomasdezeeuw/socket2 that referenced this pull request Aug 13, 2022
So we can use the I/O safety feature stabilised in 1.63:
rust-lang/rust#95118.
Thomasdezeeuw added a commit to rust-lang/socket2 that referenced this pull request Aug 13, 2022
So we can use the I/O safety feature stabilised in 1.63:
rust-lang/rust#95118.
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-libs Relevant to the library team, which will review and decide on the PR/issue.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Tracking Issue for RFC 3128: I/O Safety
7 participants