Skip to content

Rollup of 6 pull requests #95321

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Closed
wants to merge 16 commits into from
Closed

Conversation

Dylan-DPC
Copy link
Member

Successful merges:

Failed merges:

r? @ghost
@rustbot modify labels: rollup

Create a similar rollup

cjgillot and others added 16 commits March 20, 2022 20:36
Taking a Diagnostic by move would break the usual pattern
`diag.label(..).emit()`.
RustyHermit now maintains custom json targets, which are distributed with the kernel. [1]

[1]: hermit-os/kernel#395
Remove `Session::one_time_diagnostic`

This is untracked mutable state, which modified the behaviour of queries.
It was used for 2 things: some full-blown errors, but mostly for lint declaration notes ("the lint level is defined here" notes).

It is replaced by the diagnostic deduplication infra which already exists in the diagnostic emitter.
A new diagnostic level `OnceNote` is introduced specifically for lint notes, to deduplicate subdiagnostics.

As a drive-by, diagnostic emission takes a `&mut` to allow dropping the `SubDiagnostic`s.
add #[must_use] to functions of slice and its iterators.

Continuation of rust-lang#92853.

Tracking issue: rust-lang#89692.
Fix inaccurate function name in `rustc_const_eval` docs

Looks to me like this fixes rust-lang#85513. I had trouble making a intra-docs link to `eval_place_to_op` work, though...
…iplett

Remove hermitkernel targets

RustyHermit now maintains custom json targets, which are distributed with the kernel: hermit-os/kernel#395

See hermit-os/hermit-rs#197 (comment)
CC: `@stlankes,` `@bstrie`
std::process docs: linkify references to output, spawn and status
@rustbot rustbot added T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue. rollup A PR which is a rollup labels Mar 26, 2022
@Dylan-DPC
Copy link
Member Author

@bors r+ rollup=never p=5

@bors
Copy link
Collaborator

bors commented Mar 26, 2022

📌 Commit 0e9f329 has been approved by Dylan-DPC

@bors bors added the S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. label Mar 26, 2022
@rust-log-analyzer
Copy link
Collaborator

The job mingw-check failed! Check out the build log: (web) (plain)

Click to see the possible cause of the failure (guessed by this bot)
    Checking rand v0.7.3
    Checking std v0.0.0 (/checkout/library/std)
    Checking core v0.0.0 (/checkout/library/core)
    Checking alloc v0.0.0 (/checkout/library/alloc)
error: unused return value of `core::slice::<impl [T]>::split_array_ref` that must be used
     |
     |
2347 |     v.split_array_ref::<7>();
     |
     |
     = note: `-D unused-must-use` implied by `-D warnings`

error: unused return value of `core::slice::<impl [T]>::split_array_mut` that must be used
     |
     |
2355 |     v.split_array_mut::<7>();


error: unused return value of `core::slice::<impl [T]>::rsplit_array_ref` that must be used
     |
     |
2363 |     v.rsplit_array_ref::<7>();


error: unused return value of `core::slice::<impl [T]>::rsplit_array_mut` that must be used
     |
     |
2371 |     v.rsplit_array_mut::<7>();

error: could not compile `core` due to 4 previous errors
Build completed unsuccessfully in 0:01:29

@Dylan-DPC
Copy link
Member Author

@bors r-

@bors bors added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Mar 26, 2022
@Dylan-DPC Dylan-DPC closed this Mar 26, 2022
@jendrikw
Copy link
Contributor

I fixed the errors.

@Dylan-DPC Dylan-DPC deleted the rollup-fn6gifq branch March 26, 2022 10:27
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
rollup A PR which is a rollup S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

10 participants