Skip to content

[beta] backport #94925 #95464

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 31, 2022
Merged

[beta] backport #94925 #95464

merged 1 commit into from
Mar 31, 2022

Conversation

lcnr
Copy link
Contributor

@lcnr lcnr commented Mar 30, 2022

backports #94925

looks like that PR might have slipped through 🤔 does it help if there's an open issue to track that in the future, or are there other things I can do to make this less likely in the future?

r? @Mark-Simulacrum

@rustbot rustbot added the T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. label Mar 30, 2022
@rust-highfive
Copy link
Contributor

⚠️ Warning ⚠️

  • Pull requests are usually filed against the master branch for this repo, but this one is against beta. Please double check that you specified the right target!

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Mar 30, 2022
@Dylan-DPC
Copy link
Member

@bors r+ rollup=never

@bors
Copy link
Collaborator

bors commented Mar 30, 2022

📌 Commit f81aea9 has been approved by Dylan-DPC

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Mar 30, 2022
@Dylan-DPC
Copy link
Member

@bors r=1

@bors
Copy link
Collaborator

bors commented Mar 30, 2022

💡 This pull request was already approved, no need to approve it again.

@bors
Copy link
Collaborator

bors commented Mar 30, 2022

📌 Commit f81aea9 has been approved by 1

@Dylan-DPC
Copy link
Member

@bors p=1

@Dylan-DPC
Copy link
Member

@bors r=Dylan-DPC

@bors
Copy link
Collaborator

bors commented Mar 30, 2022

💡 This pull request was already approved, no need to approve it again.

@bors
Copy link
Collaborator

bors commented Mar 30, 2022

📌 Commit f81aea9 has been approved by Dylan-DPC

@Mark-Simulacrum
Copy link
Member

Beta backports aren't done on a very frequent basis, I think this was just in queue to be backported.

@bors
Copy link
Collaborator

bors commented Mar 31, 2022

⌛ Testing commit f81aea9 with merge edbed40...

@bors
Copy link
Collaborator

bors commented Mar 31, 2022

☀️ Test successful - checks-actions
Approved by: Dylan-DPC
Pushing edbed40 to beta...

@bors bors added the merged-by-bors This PR was explicitly merged by bors. label Mar 31, 2022
@bors bors merged commit edbed40 into rust-lang:beta Mar 31, 2022
@rustbot rustbot added this to the 1.60.0 milestone Mar 31, 2022
@lcnr lcnr deleted the backport-94925 branch March 31, 2022 09:47
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers
No reviews
Assignees

@Mark-Simulacrum Mark-Simulacrum

Labels
merged-by-bors This PR was explicitly merged by bors. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
1.60.0
Development

Successfully merging this pull request may close these issues.
6 participants
@lcnr @rust-highfive @Dylan-DPC @bors @Mark-Simulacrum @rustbot