Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

Remove unneeded to_string call #95495

Merged
merged 1 commit into from
Mar 31, 2022
Merged

Remove unneeded to_string call #95495

merged 1 commit into from
Mar 31, 2022

Conversation

GuillaumeGomez
Copy link
Member

Fixes a confusion I made when reading @camelid's comment here.

r? @notriddle

@GuillaumeGomez GuillaumeGomez added C-cleanup Category: PRs that clean code up or issues documenting cleanup. T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue. labels Mar 30, 2022
@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Mar 30, 2022
@notriddle
Copy link
Contributor

@bors r+ rollup=always

@bors
Copy link
Contributor

bors commented Mar 30, 2022

📌 Commit 8c0a8f5 has been approved by notriddle

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Mar 30, 2022
@Dylan-DPC Dylan-DPC mentioned this pull request Mar 31, 2022
Merged
bors added a commit to rust-lang-ci/rust that referenced this pull request Mar 31, 2022
@bors
Auto merge of rust-lang#95511 - Dylan-DPC:rollup-4n880fd, r=Dylan-DPC
0331491 
Rollup of 5 pull requests

Successful merges:

 - rust-lang#95445 (Don't build the full compiler before running unit tests)
 - rust-lang#95470 (Fix last rustdoc-gui spurious test)
 - rust-lang#95478 (Add note to the move size diagnostic)
 - rust-lang#95495 (Remove unneeded `to_string` call)
 - rust-lang#95505 (Fix library/std compilation on openbsd.)

Failed merges:

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit 57206d7 into rust-lang:master Mar 31, 2022
@rustbot rustbot added this to the 1.61.0 milestone Mar 31, 2022
@GuillaumeGomez GuillaumeGomez deleted the rm-unneeded-to-string branch March 31, 2022 16:54
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@notriddle notriddle notriddle approved these changes

Assignees

@notriddle notriddle

Labels
C-cleanup Category: PRs that clean code up or issues documenting cleanup. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
1.61.0
Development

Successfully merging this pull request may close these issues.
5 participants
@GuillaumeGomez @notriddle @bors @rust-highfive @rustbot