Skip to content

Respect ranlib specified for target during LLVM build #96080

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Merged
merged 1 commit into from
Apr 18, 2022

Conversation

nikic
Copy link
Contributor

@nikic nikic commented Apr 15, 2022

The ranlib specified for the target was never actually transferred
into the builder configuration. In the dist-x86_64-linux build we
ended up using ranlib instead of llvm-ranlib.

Found this investigating a build failure in #94214.

The ranlib specified for the target was never actually transferred
into the builder configuration. In the dist-x86_64-linux build we
ended up using ranlib instead of llvm-ranlib.
@rust-highfive
Copy link
Contributor

r? @Mark-Simulacrum

(rust-highfive has picked a reviewer for you, use r? to override)

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Apr 15, 2022
@Mark-Simulacrum
Copy link
Member

@bors r+ rollup=iffy

@bors
Copy link
Collaborator

bors commented Apr 16, 2022

📌 Commit dcc3554 has been approved by Mark-Simulacrum

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Apr 16, 2022
@bors
Copy link
Collaborator

bors commented Apr 18, 2022

⌛ Testing commit dcc3554 with merge 747fd8d0d0edd0618e048961a30d7cdada4ae3c5...

@bors
Copy link
Collaborator

bors commented Apr 18, 2022

💔 Test failed - checks-actions

@bors bors added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Apr 18, 2022
@rust-log-analyzer
Copy link
Collaborator

The job x86_64-gnu-tools failed! Check out the build log: (web) (plain)

Click to see the possible cause of the failure (guessed by this bot)
    
    --- stdout
    
    running 8 tests
    test /tmp/mdbook-ASffHL/c-tips/index.md - Tips_for_embedded_C_developers::Iterators_vs_Array_Access (line 183) ... ignored
    test /tmp/mdbook-ASffHL/c-tips/index.md - Tips_for_embedded_C_developers::Volatile_Access (line 262) ... ignored
    test /tmp/mdbook-ASffHL/c-tips/index.md - Tips_for_embedded_C_developers::Packed_and_Aligned_Types (line 350) ... FAILED
    test /tmp/mdbook-ASffHL/c-tips/index.md - Tips_for_embedded_C_developers::Preprocessor::Compile_Time_Code_Selection (line 44) ... ok
    test /tmp/mdbook-ASffHL/c-tips/index.md - Tips_for_embedded_C_developers::Preprocessor::Compile_Time_Sizes_and_Computation (line 78) ... ok
    test /tmp/mdbook-ASffHL/c-tips/index.md - Tips_for_embedded_C_developers::Packed_and_Aligned_Types (line 312) ... ok
    test /tmp/mdbook-ASffHL/c-tips/index.md - Tips_for_embedded_C_developers::Packed_and_Aligned_Types (line 330) ... ok
    test /tmp/mdbook-ASffHL/c-tips/index.md - Tips_for_embedded_C_developers::Packed_and_Aligned_Types (line 373) ... ok
    failures:
    
    
    ---- /tmp/mdbook-ASffHL/c-tips/index.md - Tips_for_embedded_C_developers::Packed_and_Aligned_Types (line 350) stdout ----
    error: reference to packed field is unaligned
      --> /tmp/mdbook-ASffHL/c-tips/index.md:361:41
    12 |     unsafe { println!("{:p} {:p} {:p}", &v.x, &v.y, &v.z) };
       |                                         ^^^^
       |
       = note: `#[deny(unaligned_references)]` on by default
       = note: `#[deny(unaligned_references)]` on by default
       = warning: this was previously accepted by the compiler but is being phased out; it will become a hard error in a future release!
       = note: for more information, see issue #82523 <https://github.com/rust-lang/rust/issues/82523>
       = note: fields of packed structs are not properly aligned, and creating a misaligned reference is undefined behavior (even if that reference is never dereferenced)
       = help: copy the field contents to a local variable, or replace the reference with a raw pointer and use `read_unaligned`/`write_unaligned` (loads and stores via `*p` must be properly aligned even when using raw pointers)
    
    error: reference to packed field is unaligned
      --> /tmp/mdbook-ASffHL/c-tips/index.md:361:53
    12 |     unsafe { println!("{:p} {:p} {:p}", &v.x, &v.y, &v.z) };
       |                                                     ^^^^
       |
       = warning: this was previously accepted by the compiler but is being phased out; it will become a hard error in a future release!
---
    
    Couldn't compile the test.
    
    failures:
        /tmp/mdbook-ASffHL/c-tips/index.md - Tips_for_embedded_C_developers::Packed_and_Aligned_Types (line 350)
    test result: FAILED. 5 passed; 1 failed; 2 ignored; 0 measured; 0 filtered out; finished in 0.21s
    
    
    --- stderr
---
.......... (60/62)
.         (62/62)


/checkout/src/test/rustdoc-gui/search-filter.goml search-filter... FAILED
[ERROR] (line 6) TimeoutError: waiting for selector "#titles" failed: timeout 30000ms exceeded: for command `wait-for: "#titles"`
Build completed unsuccessfully in 0:00:42

@nikic
Copy link
Contributor Author

nikic commented Apr 18, 2022

@bors retry #93784

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Apr 18, 2022
@bors
Copy link
Collaborator

bors commented Apr 18, 2022

⌛ Testing commit dcc3554 with merge 491f619...

@bors
Copy link
Collaborator

bors commented Apr 18, 2022

☀️ Test successful - checks-actions
Approved by: Mark-Simulacrum
Pushing 491f619 to master...

@bors bors added the merged-by-bors This PR was explicitly merged by bors. label Apr 18, 2022
@bors bors merged commit 491f619 into rust-lang:master Apr 18, 2022
@rustbot rustbot added this to the 1.62.0 milestone Apr 18, 2022
@rust-timer
Copy link
Collaborator

Finished benchmarking commit (491f619): comparison url.

Summary:

  • Primary benchmarks: 🎉 relevant improvement found
  • Secondary benchmarks: 🎉 relevant improvements found
Regressions 😿
(primary)
Regressions 😿
(secondary)
Improvements 🎉
(primary)
Improvements 🎉
(secondary)
All 😿 🎉
(primary)
count1 0 0 1 2 1
mean2 N/A N/A -2.2% -1.2% -2.2%
max N/A N/A -2.2% -1.2% -2.2%

If you disagree with this performance assessment, please file an issue in rust-lang/rustc-perf.

@rustbot label: -perf-regression

Footnotes

  1. number of relevant changes

  2. the arithmetic mean of the percent change

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
merged-by-bors This PR was explicitly merged by bors. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants