rustdoc: Rename def_id into item_id when the type is ItemId for readability
#96118
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Some changes occurred in cc @camelid |
rustbot
added
the
T-rustdoc
rust-highfive
added
the
S-waiting-on-review
GuillaumeGomez
changed the title
def_id into item_id when the type is ItemId for readabilitydef_id into item_id when the type is ItemId for readability
|
@bors r+ rollup=always |
|
📌 Commit b1e6211 has been approved by |
bors
added
S-waiting-on-bors
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Apr 16, 2022
Rollup of 7 pull requests Successful merges: - rust-lang#94985 (Parse inner attributes on inline const block) - rust-lang#95006 (Reject `#[thread_local]` attribute on non-static items) - rust-lang#95426 (Include Refs in Valtree Creation) - rust-lang#95908 (Inline `shallow_resolve_ty` into `ShallowResolver`) - rust-lang#96058 (separate flock implementations into separate modules) - rust-lang#96088 (Update mdbook) - rust-lang#96118 (rustdoc: Rename `def_id` into `item_id` when the type is `ItemId` for readability) Failed merges: r? `@ghost` `@rustbot` modify labels: rollup
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As @notriddle mentioned in #96091, the field name is inaccurate. This PR fixes it by renaming it accordingly to its real type.
r? @notriddle