Skip to content

Add test for crt-static+lto+rwlock issue. #96208

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

Add test for crt-static+lto+rwlock issue. #96208

wants to merge 1 commit into from

Conversation

m-ou-se
Copy link
Member

@m-ou-se m-ou-se commented Apr 19, 2022

This adds a test for #94564

Closes #94564

@rustbot rustbot added the T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. label Apr 19, 2022
@rust-highfive
Copy link
Contributor

r? @Mark-Simulacrum

(rust-highfive has picked a reviewer for you, use r? to override)

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Apr 19, 2022
@rust-log-analyzer

This comment has been minimized.

# to view
@m-ou-se m-ou-se mentioned this pull request Apr 19, 2022
Open
@Mark-Simulacrum Mark-Simulacrum added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Apr 24, 2022
@Mark-Simulacrum
Copy link
Member

"r=me" on the test, but seems like we can't actually land this yet as-is. Maybe worth landing as a failing test case so we at least know when we've fixed it?

@rust-log-analyzer

This comment has been minimized.

# to view
@m-ou-se m-ou-se added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Jun 8, 2022
@m-ou-se
Copy link
Member Author

m-ou-se commented Jun 8, 2022

Updated to include -Crpath=no, since rpath/runpath must be unset when using crt-static. This is what caused the CI failure.

@Mark-Simulacrum
Copy link
Member

I'm OK with merging this -- the test seems like a good start -- but I think we shouldn't mark it as closing the issue, per my comment on the issue (#94564 (comment)). r=me with a comment added to the test about the rpath behavior (either a "we should do better" or at least explaining the context a little).

@Mark-Simulacrum Mark-Simulacrum added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jun 9, 2022
@JohnCSimon
Copy link
Member

@m-ou-se
Ping from triage: I'm closing this due to inactivity, Please reopen when you are ready to continue with this.
Note: if you do please open the PR BEFORE you push to it, else you won't be able to reopen - this is a quirk of github.
Thanks for your contribution.

@rustbot label: +S-inactive

@JohnCSimon JohnCSimon closed this Jan 29, 2023
@rustbot rustbot added the S-inactive Status: Inactive and waiting on the author. This is often applied to closed PRs. label Jan 29, 2023
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers
No reviews
Assignees

@Mark-Simulacrum Mark-Simulacrum

Labels
S-inactive Status: Inactive and waiting on the author. This is often applied to closed PRs. S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Binary crashes when statically linked with LTO turned on
6 participants
@m-ou-se @rust-highfive @rust-log-analyzer @Mark-Simulacrum @JohnCSimon @rustbot