Windows: Make stdin pipes synchronous #96441
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Stdin pipes do not need to be used asynchronously within the standard library.
ChrisDenton
added
O-windows
This comment was marked as off-topic.
This comment was marked as off-topic.
rust-highfive
added
the
S-waiting-on-review
m-ou-se
reviewed
Apr 27, 2022
|
Very nice! r=me |
m-ou-se
reviewed
Apr 27, 2022
ChrisDenton
force-pushed
the
sync-pipes
branch
2 times, most recently
from
5170b98 to
fa3bffb
Compare
|
Comments updated with a fuller explanation and issue link. @bors r=m-ou-se |
|
📌 Commit 1e7c156 has been approved by |
bors
added
S-waiting-on-bors
|
☀️ Test successful - checks-actions |
|
Finished benchmarking commit (ddb7fbe): comparison url. Summary: This benchmark run did not return any relevant results. If you disagree with this performance assessment, please file an issue in rust-lang/rustc-perf. @rustbot label: -perf-regression |
Dylan-DPC
added a commit
to Dylan-DPC/rust
that referenced
this pull request
May 15, 2022
Fix use of SetHandleInformation on UWP The use of `SetHandleInformation` (introduced in rust-lang#96441 to make `HANDLE` inheritable) breaks UWP builds because it is not available for UWP targets. Proposed workaround: duplicate the `HANDLE` with `inherit = true` and immediately close the old one. Traditional Windows Desktop programs are not affected. cc `@ChrisDenton`
This was referenced May 17, 2022
Mark-Simulacrum
added a commit
to Mark-Simulacrum/rust
that referenced
this pull request
May 17, 2022
JohnTitor
added a commit
to JohnTitor/rust
that referenced
this pull request
May 18, 2022
…u-se Revert "Auto merge of rust-lang#96441 - ChrisDenton:sync-pipes, r=m-ou-se" This reverts commit ddb7fbe. Partially addresses rust-lang#97124, but not marking as fixed as we're still pending on a beta backport (for 1.62, which is happening in rust-lang#97088). r? `@m-ou-se` `@ChrisDenton`
JohnTitor
added a commit
to JohnTitor/rust
that referenced
this pull request
May 18, 2022
…u-se Revert "Auto merge of rust-lang#96441 - ChrisDenton:sync-pipes, r=m-ou-se" This reverts commit ddb7fbe. Partially addresses rust-lang#97124, but not marking as fixed as we're still pending on a beta backport (for 1.62, which is happening in rust-lang#97088). r? ``@m-ou-se`` ``@ChrisDenton``
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
May 19, 2022
Rollup of 6 pull requests Successful merges: - rust-lang#96866 (Switch CI bucket uploads to intelligent tiering) - rust-lang#97062 (Couple of refactorings to cg_ssa::base::codegen_crate) - rust-lang#97127 (Revert "Auto merge of rust-lang#96441 - ChrisDenton:sync-pipes, r=m-ou-se") - rust-lang#97131 (Improve println! documentation) - rust-lang#97139 (Move some settings DOM generation out of JS) - rust-lang#97152 (Update cargo) Failed merges: r? `@ghost` `@rustbot` modify labels: rollup
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stdin pipes do not need to be used asynchronously within the standard library. This is a first step in making pipes mostly synchronous.
r? @m-ou-se