Skip to content

Revert "impl From<&[T; N]> and From<&mut [T; N]> for Vec<T>" #96489

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 29, 2022
Merged

Revert "impl From<&[T; N]> and From<&mut [T; N]> for Vec<T>" #96489

merged 1 commit into from
Apr 29, 2022

Conversation

shepmaster
Copy link
Member

This reverts commit 5dd7027.

@rustbot rustbot added the T-libs Relevant to the library team, which will review and decide on the PR/issue. label Apr 27, 2022
@rust-highfive
Copy link
Contributor

Hey! It looks like you've submitted a new PR for the library teams!

If this PR contains changes to any rust-lang/rust public library APIs then please comment with r? rust-lang/libs-api @rustbot label +T-libs-api -T-libs to request review from a libs-api team reviewer. If you're unsure where your change falls no worries, just leave it as is and the reviewer will take a look and make a decision to forward on if necessary.

Examples of T-libs-api changes:

  • Stabilizing library features
  • Introducing insta-stable changes such as new implementations of existing stable traits on existing stable types
  • Introducing new or changing existing unstable library APIs (excluding permanently unstable features / features without a tracking issue)
  • Changing public documentation in ways that create new stability guarantees
  • Changing observable runtime behavior of library APIs

@rust-highfive
Copy link
Contributor

r? @Mark-Simulacrum

(rust-highfive has picked a reviewer for you, use r? to override)

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Apr 27, 2022
@shepmaster
Copy link
Member Author

r? rust-lang/libs-api @rustbot label +T-libs-api -T-libs

@rustbot rustbot added the T-libs-api Relevant to the library API team, which will review and decide on the PR/issue. label Apr 27, 2022
@rustbot rustbot removed the T-libs Relevant to the library team, which will review and decide on the PR/issue. label Apr 27, 2022
This was referenced Apr 27, 2022
Merged
Closed
@yaahc
Copy link
Member

yaahc commented Apr 27, 2022

@bors r+

@bors
Copy link
Collaborator

bors commented Apr 27, 2022

📌 Commit 762bb1f has been approved by yaahc

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Apr 27, 2022
@lcnr lcnr added the beta-nominated Nominated for backporting to the compiler in the beta channel. label Apr 28, 2022
@lcnr
Copy link
Contributor

lcnr commented Apr 28, 2022

fixes #96074 which is already on beta

@jdahlstrom
Copy link

jdahlstrom commented Apr 28, 2022 •
edited
Loading

fixes #96074 which is already on beta

Thanks. I wondered why this was reverted.

@m-ou-se m-ou-se added the beta-accepted Accepted for backporting to the compiler in the beta channel. label Apr 28, 2022
@ehuss ehuss mentioned this pull request Apr 29, 2022
Merged
Dylan-DPC added a commit to Dylan-DPC/rust that referenced this pull request Apr 29, 2022
@Dylan-DPC
Rollup merge of rust-lang#96489 - shepmaster:revert-vec-from-array-re…
9a47c39 
…f, r=yaahc

Revert "impl From<&[T; N]> and From<&mut [T; N]> for Vec<T>"

This reverts commit 5dd7027.
@Dylan-DPC Dylan-DPC mentioned this pull request Apr 29, 2022
Closed
@bors
Copy link
Collaborator

bors commented Apr 29, 2022

⌛ Testing commit 762bb1f with merge 05d8dd159eb5ee8ab1d24171da50c4311c5771b0...

@bors
Copy link
Collaborator

bors commented Apr 29, 2022

💔 Test failed - checks-actions

@bors bors added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Apr 29, 2022
@rust-log-analyzer
Copy link
Collaborator

The job x86_64-gnu-tools failed! Check out the build log: (web) (plain)

Click to see the possible cause of the failure (guessed by this bot) 
.......... (60/62)
.         (62/62)


/checkout/src/test/rustdoc-gui/search-tab-selection-if-current-is-empty.goml search-tab-selection-if-current-is-empty... FAILED
[ERROR] (line 6) TimeoutError: waiting for selector "#titles" failed: timeout 30000ms exceeded: for command `wait-for: "#titles"`
Build completed unsuccessfully in 0:00:44

@lcnr
Copy link
Contributor

lcnr commented Apr 29, 2022

spurious probably

@bors retry

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Apr 29, 2022
@bors
Copy link
Collaborator

bors commented Apr 29, 2022

⌛ Testing commit 762bb1f with merge f1d8a7d...

@bors
Copy link
Collaborator

bors commented Apr 29, 2022

☀️ Test successful - checks-actions
Approved by: yaahc
Pushing f1d8a7d to master...

@bors bors added the merged-by-bors This PR was explicitly merged by bors. label Apr 29, 2022
@bors bors merged commit f1d8a7d into rust-lang:master Apr 29, 2022
@rustbot rustbot added this to the 1.62.0 milestone Apr 29, 2022
@shepmaster shepmaster deleted the revert-vec-from-array-ref branch April 29, 2022 17:38
@rust-timer
Copy link
Collaborator

Finished benchmarking commit (f1d8a7d): comparison url.

Summary: This benchmark run did not return any relevant results.

If you disagree with this performance assessment, please file an issue in rust-lang/rustc-perf.

@rustbot label: -perf-regression

ehuss pushed a commit to ehuss/rust that referenced this pull request May 4, 2022
@bors @ehuss
Auto merge of rust-lang#96489 - shepmaster:revert-vec-from-array-ref,…
d55330c 
… r=yaahc

Revert "impl From<&[T; N]> and From<&mut [T; N]> for Vec<T>"

This reverts commit 5dd7027.
@ehuss ehuss mentioned this pull request May 4, 2022
Merged
@ehuss ehuss modified the milestones: 1.62.0, 1.61.0 May 4, 2022
@ehuss ehuss removed the beta-nominated Nominated for backporting to the compiler in the beta channel. label May 4, 2022
bors added a commit to rust-lang-ci/rust that referenced this pull request May 4, 2022
@bors
Auto merge of rust-lang#96692 - ehuss:beta-backports, r=ehuss
cf5fd89 
[beta] Beta backports

* Revert diagnostic duplication and accidental stabilization rust-lang#96516
* Revert "Re-export core::ffi types from std::ffi" rust-lang#96492
* Make [e]println macros eagerly drop temporaries (for backport) rust-lang#96490
* Revert "impl From<&[T; N]> and From<&mut [T; N]> for Vec<T>" rust-lang#96489
* Cargo:
    * move workspace inheritance unstable docs to the correct place (rust-lang/cargo#10616)
MabezDev pushed a commit to esp-rs/rust that referenced this pull request May 17, 2022
@bors @MabezDev
Auto merge of rust-lang#96489 - shepmaster:revert-vec-from-array-ref,…
bed7d84 
… r=yaahc

Revert "impl From<&[T; N]> and From<&mut [T; N]> for Vec<T>"

This reverts commit 5dd7027.
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers
No reviews
Assignees

@m-ou-se m-ou-se

Labels
beta-accepted Accepted for backporting to the compiler in the beta channel. merged-by-bors This PR was explicitly merged by bors. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-libs-api Relevant to the library API team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
1.61.0
Development

Successfully merging this pull request may close these issues.