Quick fix for #96223. #96679
Merged
Quick fix for #96223. #96679
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rustbot
added
the
T-compiler
|
Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @jackh726 (or someone else) soon. Please see the contribution instructions for more information. |
rust-highfive
added
the
S-waiting-on-review
jackh726
requested changes
May 3, 2022
compiler/rustc_trait_selection/src/traits/error_reporting/suggestions.rs
Outdated
Show resolved
Hide resolved
|
Awesome. @bors r+ rollup |
|
@bors r+ rollup |
|
📌 Commit 574bee3 has been approved by |
bors
added
S-waiting-on-bors
JohnTitor
added a commit
to JohnTitor/rust
that referenced
this pull request
May 3, 2022
…kh726 Quick fix for rust-lang#96223. This PR is a quick fix regarding rust-lang#96223. As mentioned in the issue, others modification could be added to not elide types with bound vars from suggestions. Special thanks to `@jackh726` for mentoring and `@Manishearth` for minimal test case. r? `@jackh726`
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
May 4, 2022
Rollup of 6 pull requests Successful merges: - rust-lang#96597 (openbsd: unbreak build on native platform) - rust-lang#96662 (Fix typo in lint levels doc) - rust-lang#96668 (Fix flaky rustdoc-ui test because it did not replace time result) - rust-lang#96679 (Quick fix for rust-lang#96223.) - rust-lang#96684 (Update `ProjectionElem::Downcast` documentation) - rust-lang#96686 (Add some TAIT-related tests) Failed merges: r? `@ghost` `@rustbot` modify labels: rollup
Manishearth
added
the
beta-nominated
|
@rust-lang/release Can this be uplifted to the beta so it makes the coming release? Without this patch ICU4X is quite prone to hitting this ICE, obscuring any real errors. |
|
Ah I meant to beta nominate, whoops. Thanks @Manishearth. |
|
This will need compile team approval though |
|
cc @rust-lang/compiler |
oli-obk
added
the
beta-accepted
|
Accepting for beta backport. This is solely on the diagnostics path, fixes a frequent ICE and is a tiny change. |
Mark-Simulacrum
removed
the
beta-nominated
Merged
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
May 14, 2022
…ulacrum [beta] backports This backports/rolls up: * Quick fix for rust-lang#96223. rust-lang#96679 * [beta] Revert rust-lang#92519 on beta rust-lang#96556 * [beta] Clippy backport ICE/infinite loop fix rust-lang#96740 * Revert "Prefer projection candidates instead of param_env candidates for Sized predicates" rust-lang#96593
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is a quick fix regarding #96223.
As mentioned in the issue, others modification could be added to not elide types with bound vars from suggestions.
Special thanks to @jackh726 for mentoring and @Manishearth for minimal test case.
r? @jackh726