Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

Disable unix::net::ancillary on BSD. #96742

Merged
merged 1 commit into from
May 26, 2022
Merged

Disable unix::net::ancillary on BSD. #96742

merged 1 commit into from
May 26, 2022

Conversation

m-ou-se
Copy link
Member

@m-ou-se m-ou-se commented May 5, 2022

@m-ou-se m-ou-se added the T-libs Relevant to the library team, which will review and decide on the PR/issue. label May 5, 2022
@rust-highfive

This comment was marked as off-topic.

# to view
@rust-highfive
Copy link
Contributor

r? @kennytm

(rust-highfive has picked a reviewer for you, use r? to override)

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label May 5, 2022
@m-ou-se m-ou-se mentioned this pull request May 5, 2022
Open
fbstj
fbstj reviewed May 6, 2022
View reviewed changes
library/std/src/os/unix/net/datagram.rs
doc,
target_os = "android",
target_os = "dragonfly",
target_os = "emscripten",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this seems to have removed emscripten as well which isn't mentioned in the PR, was this intentional?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this seems to have removed emscripten as well which isn't mentioned in the PR, was this intentional?

Comment not resolved too, yes?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I merged this intentionally knowing that it did remove other platforms as well.

@bors
Copy link
Collaborator

bors commented May 10, 2022

☔ The latest upstream changes (presumably #96904) made this pull request unmergeable. Please resolve the merge conflicts.

@joshtriplett
Copy link
Member

@bors r+

@bors
Copy link
Collaborator

bors commented May 25, 2022

📌 Commit 685192de96050a9674331197a8b34aaacf189d17 has been approved by joshtriplett

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels May 25, 2022
@klensy
Copy link
Contributor

klensy commented May 25, 2022

Merge branch 'master' into bsd-no-ancillary

No-Merge Policy?

@joshtriplett
Copy link
Member

Merge branch 'master' into bsd-no-ancillary

No-Merge Policy?

Didn't realize github's conflict resolution tool would cause a problem. Should I rebase and push to the branch instead?

@klensy
Copy link
Contributor

klensy commented May 25, 2022

Yes, rebase + force push should work.

@JohnTitor
Copy link
Member

@bors r- to resolve above

@bors bors added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels May 25, 2022
@joshtriplett
Copy link
Member

@klensy @JohnTitor Done.

@JohnTitor
Copy link
Member

@bors r=joshtriplett

@bors
Copy link
Collaborator

bors commented May 26, 2022

📌 Commit 8b9f8e2 has been approved by joshtriplett

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels May 26, 2022
@bors
Copy link
Collaborator

bors commented May 26, 2022

⌛ Testing commit 8b9f8e2 with merge 9e26dc7...

@bors
Copy link
Collaborator

bors commented May 26, 2022

☀️ Test successful - checks-actions
Approved by: joshtriplett
Pushing 9e26dc7 to master...

@bors bors added the merged-by-bors This PR was explicitly merged by bors. label May 26, 2022
@bors bors merged commit 9e26dc7 into rust-lang:master May 26, 2022
@rustbot rustbot added this to the 1.63.0 milestone May 26, 2022
@bors bors mentioned this pull request May 26, 2022
Merged
@rust-timer
Copy link
Collaborator

Finished benchmarking commit (9e26dc7): comparison url.

Instruction count

This benchmark run did not return any relevant results for this metric.

Max RSS (memory usage)

Results
  • Primary benchmarks: 😿 relevant regression found
  • Secondary benchmarks: 😿 relevant regressions found
mean1 max count2
Regressions 😿
(primary)		 2.2% 2.2% 1
Regressions 😿
(secondary)		 1.5% 2.3% 4
Improvements 🎉
(primary)		 N/A N/A 0
Improvements 🎉
(secondary)		 N/A N/A 0
All 😿🎉 (primary) 2.2% 2.2% 1

Cycles

Results
  • Primary benchmarks: mixed results
  • Secondary benchmarks: mixed results
mean1 max count2
Regressions 😿
(primary)		 2.5% 2.5% 1
Regressions 😿
(secondary)		 3.8% 4.6% 2
Improvements 🎉
(primary)		 -2.1% -2.1% 1
Improvements 🎉
(secondary)		 -2.2% -2.2% 1
All 😿🎉 (primary) 0.2% 2.5% 2

If you disagree with this performance assessment, please file an issue in rust-lang/rustc-perf.

@rustbot label: -perf-regression

Footnotes

  1. the arithmetic mean of the percent change ↩ ↩2

  2. number of relevant changes ↩ ↩2

# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@fbstj fbstj fbstj left review comments

@joshtriplett joshtriplett joshtriplett left review comments

@klensy klensy klensy left review comments

Assignees

@kennytm kennytm

Labels
merged-by-bors This PR was explicitly merged by bors. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-libs Relevant to the library team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
1.63.0
Development

Successfully merging this pull request may close these issues.
10 participants
@m-ou-se @rust-highfive @bors @joshtriplett @klensy @JohnTitor @rust-timer @fbstj @kennytm @rustbot