Skip to content

Remove some unnecessary rustc_allow_const_fn_unstable attributes. #97003

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom
Merged
merged 1 commit into from
May 13, 2022
Merged

Remove some unnecessary rustc_allow_const_fn_unstable attributes. #97003

merged 1 commit into from
May 13, 2022

Conversation

nnethercote
Copy link
Contributor

@nnethercote nnethercote requested a review from fee1-dead May 13, 2022 06:02
@rust-highfive
Copy link
Contributor

Hey! It looks like you've submitted a new PR for the library teams!

If this PR contains changes to any rust-lang/rust public library APIs then please comment with r? rust-lang/libs-api @rustbot label +T-libs-api -T-libs to request review from a libs-api team reviewer. If you're unsure where your change falls no worries, just leave it as is and the reviewer will take a look and make a decision to forward on if necessary.

Examples of T-libs-api changes:

  • Stabilizing library features
  • Introducing insta-stable changes such as new implementations of existing stable traits on existing stable types
  • Introducing new or changing existing unstable library APIs (excluding permanently unstable features / features without a tracking issue)
  • Changing public documentation in ways that create new stability guarantees
  • Changing observable runtime behavior of library APIs

@rustbot rustbot added the T-libs Relevant to the library team, which will review and decide on the PR/issue. label May 13, 2022
@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label May 13, 2022
@nnethercote
Copy link
Contributor Author

@bors rollup=always

@nnethercote
Copy link
Contributor Author

I don't know much about these annotations other than removing seems to have no observable effect.

@fee1-dead
Copy link
Member

Yeah, most of these are obsolete or already stabilized, other than to allow a compile error the attribute does not do anything spectacular. If it does not error then fine to me.

@bors r+

@bors
Copy link
Collaborator

bors commented May 13, 2022

📌 Commit fd01fbc has been approved by fee1-dead

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels May 13, 2022
@matthiaskrgr matthiaskrgr mentioned this pull request May 13, 2022
Merged
bors added a commit to rust-lang-ci/rust that referenced this pull request May 13, 2022
@bors
Auto merge of rust-lang#97013 - matthiaskrgr:rollup-c1pc6pc, r=matthi…
f1f721e 
…askrgr

Rollup of 5 pull requests

Successful merges:

 - rust-lang#96154 (Expand core::hint::unreachable_unchecked() docs)
 - rust-lang#96615 (Add a regression test for rust-lang#54779)
 - rust-lang#96982 (fix clippy expect_fun_call)
 - rust-lang#97003 (Remove some unnecessary `rustc_allow_const_fn_unstable` attributes.)
 - rust-lang#97011 (Add regression test for rust-lang#28935)

Failed merges:

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit a56211a into rust-lang:master May 13, 2022
@rustbot rustbot added this to the 1.62.0 milestone May 13, 2022
@nnethercote nnethercote deleted the rm-const_fn-attrs branch May 15, 2022 23:18
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@fee1-dead fee1-dead fee1-dead approved these changes

Assignees

@fee1-dead fee1-dead

Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-libs Relevant to the library team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
1.62.0
Development

Successfully merging this pull request may close these issues.
5 participants
@nnethercote @rust-highfive @fee1-dead @bors @rustbot