Skip to content

Update MIR passes to handle unwinding Inline Asm #97103

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom
Merged
merged 2 commits into from
May 19, 2022
Merged

Update MIR passes to handle unwinding Inline Asm #97103

merged 2 commits into from
May 19, 2022

Conversation

luqmana
Copy link
Member

@luqmana luqmana commented May 17, 2022

Some more follow up fixes from #95864 (comment)

r? @Amanieu

@rustbot rustbot added the T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. label May 17, 2022
@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label May 17, 2022
@rust-log-analyzer

This comment has been minimized.

# to view
Amanieu
Amanieu reviewed May 17, 2022
View reviewed changes
Copy link
Member

@Amanieu Amanieu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM apart from a nit about naming.

@Amanieu
Copy link
Member

Amanieu commented May 18, 2022

@bors t+

@tmiasko
Copy link
Contributor

tmiasko commented May 18, 2022

Could you squash the last commit that reverts earlier changes?

@bors delegate=luqmana

@bors
Copy link
Collaborator

bors commented May 18, 2022

✌️ @luqmana can now approve this pull request

@luqmana luqmana force-pushed the asm-unwind-cleanup branch from 552f1e0 to 39cd1da Compare May 18, 2022 20:44
@luqmana
Copy link
Member Author

luqmana commented May 18, 2022

@bors r=Amanieu,tmiasko

@bors
Copy link
Collaborator

bors commented May 18, 2022

📌 Commit 39cd1da has been approved by Amanieu,tmiasko

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels May 18, 2022
JohnTitor added a commit to JohnTitor/rust that referenced this pull request May 18, 2022
@JohnTitor
Rollup merge of rust-lang#97103 - luqmana:asm-unwind-cleanup, r=Amani…
592255c 
…eu,tmiasko

Update MIR passes to handle unwinding Inline Asm

Some more follow up fixes from rust-lang#95864 (comment)

r? `@Amanieu`
@JohnTitor JohnTitor mentioned this pull request May 18, 2022
Closed
@JohnTitor
Copy link
Member

Failed in rollup: #97157 (comment)
@bors r-

@bors bors added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels May 18, 2022
@luqmana luqmana force-pushed the asm-unwind-cleanup branch from 39cd1da to af7f53d Compare May 19, 2022 06:15
@luqmana
Copy link
Member Author

luqmana commented May 19, 2022

@bors r=Amanieu,tmiasko

@bors
Copy link
Collaborator

bors commented May 19, 2022

📌 Commit af7f53d has been approved by Amanieu,tmiasko

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels May 19, 2022
@bors
Copy link
Collaborator

bors commented May 19, 2022

⌛ Testing commit af7f53d with merge 67a9bcb...

@bors
Copy link
Collaborator

bors commented May 19, 2022

☀️ Test successful - checks-actions
Approved by: Amanieu,tmiasko
Pushing 67a9bcb to master...

@bors bors added the merged-by-bors This PR was explicitly merged by bors. label May 19, 2022
@bors bors merged commit 67a9bcb into rust-lang:master May 19, 2022
@rustbot rustbot added this to the 1.63.0 milestone May 19, 2022
@rust-timer
Copy link
Collaborator

rust-timer commented May 19, 2022 •
edited by rylev
Loading

Finished benchmarking commit (67a9bcb): comparison url.

Instruction count

This benchmark run did not return any relevant results for this metric.

Max RSS (memory usage)

Results
  • Primary benchmarks: no relevant changes found
  • Secondary benchmarks: 😿 relevant regressions found
Regressions 😿
(primary)		 Regressions 😿
(secondary)		 Improvements 🎉
(primary)		 Improvements 🎉
(secondary)		 All 😿 🎉
(primary)
count1 0 5 0 0 0
mean2 N/A 2.7% N/A N/A N/A
max N/A 4.3% N/A N/A N/A

Cycles

Results
  • Primary benchmarks: mixed results
  • Secondary benchmarks: mixed results
Regressions 😿
(primary)		 Regressions 😿
(secondary)		 Improvements 🎉
(primary)		 Improvements 🎉
(secondary)		 All 😿 🎉
(primary)
count1 3 1 2 2 5
mean2 3.2% 2.0% -2.4% -2.9% 1.0%
max 4.2% 2.0% -2.6% -3.9% 4.2%

If you disagree with this performance assessment, please file an issue in rust-lang/rustc-perf.

@rustbot label: -perf-regression

Footnotes

  1. number of relevant changes ↩ ↩2

  2. the arithmetic mean of the percent change ↩ ↩2

@luqmana luqmana deleted the asm-unwind-cleanup branch May 19, 2022 18:22
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@Amanieu Amanieu Amanieu left review comments

Assignees

@Amanieu Amanieu

Labels
merged-by-bors This PR was explicitly merged by bors. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
1.63.0
Development

Successfully merging this pull request may close these issues.
9 participants
@luqmana @rust-log-analyzer @Amanieu @tmiasko @bors @JohnTitor @rust-timer @rust-highfive @rustbot