Say "last" instead of "rightmost" in the documentation for std::str:rfind
#97192
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…:rfind`. In the documentation comment for `std::str::rfind`, say "last" instead of "rightmost" to describe the match that `rfind` finds. This follows the spirit of rust-lang#30459, for which `trim_left` and `trim_right` were replaced by `trim_start` and `trim_end` to be more clear about how they work on text which is displayed right-to-left.
sunfishcode
added
the
T-libs
|
Hey! It looks like you've submitted a new PR for the library teams! If this PR contains changes to any Examples of
|
|
r? @thomcc (rust-highfive has picked a reviewer for you, use r? to override) |
rust-highfive
added
the
S-waiting-on-review
|
@bors r+ rollup |
|
📌 Commit b836cf6 has been approved by |
bors
added
S-waiting-on-bors
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
May 20, 2022
…laumeGomez Rollup of 6 pull requests Successful merges: - rust-lang#96565 (rustdoc: show implementations on `#[fundamental]` wrappers) - rust-lang#97179 (Add new lint to enforce whitespace after keywords) - rust-lang#97185 (interpret/validity: separately control checking numbers for being init and non-ptr) - rust-lang#97188 (Remove unneeded null pointer asserts in ptr2int casts) - rust-lang#97189 (Update .mailmap) - rust-lang#97192 (Say "last" instead of "rightmost" in the documentation for `std::str:rfind`) Failed merges: r? `@ghost` `@rustbot` modify labels: rollup
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the documentation comment for
std::str::rfind, say "last" insteadof "rightmost" to describe the match that
rfindfinds. This follows thespirit of #30459, for which
trim_leftandtrim_rightwere replaced bytrim_startandtrim_endto be more clear about how they work ontext which is displayed right-to-left.