On E0204 suggest missing type param bounds #97664

estebank · 2022-06-02T19:35:29Z

error[E0204]: the trait `Copy` may not be implemented for this type
  --> f42.rs:9:17
   |
9  | #[derive(Debug, Copy, Clone)]
   |                 ^^^^
10 | pub struct AABB<K>{
11 |     pub loc: Vector2<K>,
   |     ------------------- this field does not implement `Copy`
12 |     pub size: Vector2<K>
   |     -------------------- this field does not implement `Copy`
   |
note: the `Copy` impl for `Vector2<K>` requires that `K: Debug`
  --> f42.rs:11:5
   |
11 |     pub loc: Vector2<K>,
   |     ^^^^^^^^^^^^^^^^^^^
note: the `Copy` impl for `Vector2<K>` requires that `K: Debug`
  --> f42.rs:12:5
   |
12 |     pub size: Vector2<K>
   |     ^^^^^^^^^^^^^^^^^^^^
   = note: this error originates in the derive macro `Copy` (in Nightly builds, run with -Z macro-backtrace for more info)
help: consider restricting type parameter `K`
   |
10 | pub struct AABB<K: Debug>{
   |                  +++++++

Fix #89137.

rust-highfive · 2022-06-02T19:35:32Z

r? @lcnr

(rust-highfive has picked a reviewer for you, use r? to override)

estebank · 2022-06-02T19:36:48Z

r? @compiler-errors

compiler-errors · 2022-06-02T19:48:00Z

This is very cool

@bors r+ rollup

bors · 2022-06-02T19:48:02Z

📌 Commit cba4868d5e78227104fcba48f3e24c62596e9f1e has been approved by compiler-errors

compiler-errors · 2022-06-02T19:52:26Z

@bors r-

r=me with the tests blessed 😺

``` error[E0204]: the trait `Copy` may not be implemented for this type --> f42.rs:9:17 | 9 | #[derive(Debug, Copy, Clone)] | ^^^^ 10 | pub struct AABB<K>{ 11 | pub loc: Vector2<K>, | ------------------- this field does not implement `Copy` 12 | pub size: Vector2<K> | -------------------- this field does not implement `Copy` | note: the `Copy` impl for `Vector2<K>` requires that `K: Debug` --> f42.rs:11:5 | 11 | pub loc: Vector2<K>, | ^^^^^^^^^^^^^^^^^^^ note: the `Copy` impl for `Vector2<K>` requires that `K: Debug` --> f42.rs:12:5 | 12 | pub size: Vector2<K> | ^^^^^^^^^^^^^^^^^^^^ = note: this error originates in the derive macro `Copy` (in Nightly builds, run with -Z macro-backtrace for more info) help: consider restricting type parameter `K` | 10 | pub struct AABB<K: Debug>{ | +++++++ ``` Fix rust-lang#89137.

estebank · 2022-06-02T20:17:02Z

@compiler-errors added another commit with a small, hopefully uncontroversial change.

@bors r=compiler-errors

bors · 2022-06-02T20:17:04Z

📌 Commit 9bfd3dd3794ab6a66140ef871fbf6171e3eef44f has been approved by compiler-errors

compiler-errors · 2022-06-02T20:19:22Z

Looks good to me, other than if the usage of FxHashMap there is going to cause hash instability in diagnostics. Maybe we should stringify first?

estebank · 2022-06-02T20:20:54Z

I think that the only issue is not with hashes but with inconsistent output in the .stderr tests, but there's a single one where there aren't multiple notes being emitted, so it should be fine for now.

compiler-errors · 2022-06-02T20:21:02Z

oh... stable_map? Did you mean to use this one? https://doc.rust-lang.org/nightly/nightly-rustc/src/rustc_data_structures/stable_map.rs.html#7

estebank · 2022-06-02T20:24:19Z

Changed :)

@bors r=compiler-errors

bors · 2022-06-02T20:24:20Z

📌 Commit 6f832eaea5b0b43264a0b17161f43d58ea5fffbb has been approved by compiler-errors

compiler-errors · 2022-06-02T20:26:42Z

Not sure what changed: https://github.com/rust-lang/rust/compare/9bfd3dd3794ab6a66140ef871fbf6171e3eef44f..6f832eaea5b0b43264a0b17161f43d58ea5fffbb

Anyways, I can follow up in a quick PR later. Sorry for the back and forth.

estebank · 2022-06-02T20:27:53Z

🤦 I'd failed to push -f

compiler-errors · 2022-06-02T20:28:04Z

There we go. Thanks 👍

compiler-errors · 2022-06-02T20:30:28Z

@bors r+

bors · 2022-06-02T20:30:29Z

📌 Commit 184576cd368c5b28192eff02bbbc88ca3a255968 has been approved by compiler-errors

compiler-errors · 2022-06-02T20:33:25Z

Oh no, haha. @bors r-

I think it's best to just .to_string() on the two keys for the map and use something sorted like a BTreeMap?

estebank · 2022-06-02T20:33:28Z

🤦

estebank · 2022-06-02T20:34:03Z

I'll make it a string in a bit

compiler-errors

Something like:

compiler-errors · 2022-06-02T20:34:42Z

compiler/rustc_typeck/src/coherence/builtin.rs

+                            errors
+                                .entry((ty, error_predicate))


Suggested change

errors

.entry((ty, error_predicate))

errors

.entry((ty.to_string(), error_predicate.to_string()))

compiler-errors · 2022-06-02T20:35:01Z

compiler/rustc_typeck/src/coherence/builtin.rs

+                    generics = self_item.kind.generics();
+                }
+            }
+            let mut errors: StableMap<_, Vec<_>> = Default::default();


Suggested change

let mut errors: StableMap<_, Vec<_>> = Default::default();

let mut errors: BTreeMap<_, Vec<_>> = Default::default();

compiler-errors · 2022-06-02T22:16:50Z

CI seems happy!

@bors r+

bors · 2022-06-02T22:16:51Z

📌 Commit f9aa2e0 has been approved by compiler-errors

Rollup of 5 pull requests Successful merges: - rust-lang#97366 (Stabilize `{slice,array}::from_ref`) - rust-lang#97653 (add cast kind of from_exposed_addr (int-to-ptr casts)) - rust-lang#97663 (take back half-baked noaliasing check in Assignment) - rust-lang#97664 (On E0204 suggest missing type param bounds) - rust-lang#97668 (rustdoc: clean up primitive.slice.html links) Failed merges: r? `@ghost` `@rustbot` modify labels: rollup

rust-highfive assigned lcnr Jun 2, 2022

rustbot added the T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. label Jun 2, 2022

rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Jun 2, 2022

rust-highfive assigned compiler-errors and unassigned lcnr Jun 2, 2022

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jun 2, 2022

This comment has been minimized.

# to view

bors added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Jun 2, 2022

estebank force-pushed the suggest-bound-derive-copy branch from cba4868 to 8567b68 Compare June 2, 2022 19:54

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Jun 2, 2022

estebank force-pushed the suggest-bound-derive-copy branch from 9bfd3dd to 6f832ea Compare June 2, 2022 20:24

estebank force-pushed the suggest-bound-derive-copy branch from 6f832ea to 184576c Compare June 2, 2022 20:27

This comment has been minimized.

# to view

bors added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Jun 2, 2022

compiler-errors reviewed Jun 2, 2022

View reviewed changes

estebank force-pushed the suggest-bound-derive-copy branch from 184576c to 1ca6938 Compare June 2, 2022 21:10

This comment has been minimized.

# to view

estebank force-pushed the suggest-bound-derive-copy branch from 1ca6938 to e5c6143 Compare June 2, 2022 21:22

This comment has been minimized.

# to view

Tweak output

f9aa2e0

estebank force-pushed the suggest-bound-derive-copy branch from e5c6143 to f9aa2e0 Compare June 2, 2022 22:04

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Jun 2, 2022

Dylan-DPC mentioned this pull request Jun 3, 2022

Rollup of 5 pull requests #97679

Merged

bors merged commit b71ddd6 into rust-lang:master Jun 3, 2022

rustbot added this to the 1.63.0 milestone Jun 3, 2022

estebank deleted the suggest-bound-derive-copy branch November 9, 2023 05:14

	let mut errors: StableMap<_, Vec<_>> = Default::default();
	let mut errors: BTreeMap<_, Vec<_>> = Default::default();

On E0204 suggest missing type param bounds #97664

On E0204 suggest missing type param bounds #97664

Uh oh!

Conversation

estebank commented Jun 2, 2022

Uh oh!

rust-highfive commented Jun 2, 2022

Uh oh!

estebank commented Jun 2, 2022

Uh oh!

compiler-errors commented Jun 2, 2022

Uh oh!

bors commented Jun 2, 2022

Uh oh!

This comment has been minimized.

compiler-errors commented Jun 2, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

estebank commented Jun 2, 2022

Uh oh!

bors commented Jun 2, 2022

Uh oh!

compiler-errors commented Jun 2, 2022

Uh oh!

estebank commented Jun 2, 2022

Uh oh!

compiler-errors commented Jun 2, 2022

Uh oh!

estebank commented Jun 2, 2022

Uh oh!

bors commented Jun 2, 2022

Uh oh!

compiler-errors commented Jun 2, 2022

Uh oh!

estebank commented Jun 2, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

compiler-errors commented Jun 2, 2022

Uh oh!

compiler-errors commented Jun 2, 2022

Uh oh!

bors commented Jun 2, 2022

Uh oh!

This comment has been minimized.

compiler-errors commented Jun 2, 2022

Uh oh!

estebank commented Jun 2, 2022

Uh oh!

estebank commented Jun 2, 2022

Uh oh!

compiler-errors left a comment

Choose a reason for hiding this comment

Uh oh!

compiler-errors Jun 2, 2022

Choose a reason for hiding this comment

Uh oh!

compiler-errors Jun 2, 2022

Choose a reason for hiding this comment

Uh oh!

This comment has been minimized.

This comment has been minimized.

compiler-errors commented Jun 2, 2022

Uh oh!

bors commented Jun 2, 2022

Uh oh!

Uh oh!

compiler-errors commented Jun 2, 2022 •

edited

Loading

estebank commented Jun 2, 2022 •

edited

Loading