Skip to content

Add #T-types/nominated zulip notification #97692

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Merged
merged 1 commit into from
Jun 4, 2022

Conversation

compiler-errors
Copy link
Member

@compiler-errors compiler-errors commented Jun 3, 2022

Add rule to create topic in aforementioned stream when I-types-nominated tag is added

@rust-highfive
Copy link
Contributor

r? @Mark-Simulacrum

(rust-highfive has picked a reviewer for you, use r? to override)

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Jun 3, 2022
Copy link
Member

@jackh726 jackh726 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Going to let @Mark-Simulacrum actually r+, but LGTM

@Mark-Simulacrum
Copy link
Member

@bors r+

@bors
Copy link
Collaborator

bors commented Jun 3, 2022

📌 Commit 7b6f25a has been approved by Mark-Simulacrum

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jun 3, 2022
@compiler-errors
Copy link
Member Author

@bors rollup

bors added a commit to rust-lang-ci/rust that referenced this pull request Jun 4, 2022
…askrgr

Rollup of 5 pull requests

Successful merges:

 - rust-lang#97446 (Make hir().get_generics and generics_of consistent.)
 - rust-lang#97656 (Add a suggestion to replace parentheses with angle brackets on associated trait constraint)
 - rust-lang#97692 (Add `#T-types/nominated` zulip notification)
 - rust-lang#97696 (Do not ICE when failing to normalize during inlining.)
 - rust-lang#97702 (Remove useless LocalDefId in ImplTraitContext::Universal.)

Failed merges:

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit 8971235 into rust-lang:master Jun 4, 2022
@rustbot rustbot added this to the 1.63.0 milestone Jun 4, 2022
@compiler-errors compiler-errors deleted the types-nominated branch August 11, 2023 20:21
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants