Skip to content

Suggest escaping box as identifier #97857

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Merged
merged 1 commit into from
Jun 9, 2022

Conversation

ChayimFriedman2
Copy link
Contributor

Fixes #97810.

@rustbot rustbot added the T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. label Jun 8, 2022
@rust-highfive
Copy link
Contributor

r? @wesleywiser

(rust-highfive has picked a reviewer for you, use r? to override)

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Jun 8, 2022
@compiler-errors
Copy link
Member

Thanks @ChayimFriedman2 !

r? @compiler-errors
@bors r+ rollup

@bors
Copy link
Collaborator

bors commented Jun 8, 2022

📌 Commit c1b1ec7 has been approved by compiler-errors

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jun 8, 2022
matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull request Jun 8, 2022
…, r=compiler-errors

Suggest escaping `box` as identifier

Fixes rust-lang#97810.
bors added a commit to rust-lang-ci/rust that referenced this pull request Jun 8, 2022
…piler-errors

Rollup of 9 pull requests

Successful merges:

 - rust-lang#97557 (Fix indices and remove some unwraps in arg mismatch algorithm)
 - rust-lang#97830 (Add std::alloc::set_alloc_error_hook example)
 - rust-lang#97856 (Don't suggest adding `let` in certain `if` conditions)
 - rust-lang#97857 (Suggest escaping `box` as identifier)
 - rust-lang#97871 (Suggest using `iter()` or `into_iter()` for `Vec`)
 - rust-lang#97882 (Add regresion test for rust-lang#67498)
 - rust-lang#97883 (Remove `ignore-compare-mode-nll` annotations from tests)
 - rust-lang#97891 (Update books)
 - rust-lang#97894 (Fix polonius compare mode.)

Failed merges:

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit f12a1c2 into rust-lang:master Jun 9, 2022
@rustbot rustbot added this to the 1.63.0 milestone Jun 9, 2022
@ChayimFriedman2 ChayimFriedman2 deleted the box-identifier-help branch June 9, 2022 02:22
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Unhelpful error message with identifiers named box
6 participants