Document unstable --extern options
#98226
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jyn514
reviewed
Jun 18, 2022
|
Looks like highfive got confused - I'll go ahead and r? @ehuss |
jyn514
added
A-resolve
jyn514
reviewed
Jun 18, 2022
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
ehuss
reviewed
Jun 21, 2022
|
I should probably squish all these commits if that's ok? |
Co-Authored-By: Joshua Nelson <github@jyn.dev> Co-Authored-By: Eric Huss <eric@huss.org>
|
Yeah, I think it would be nice to squash :) |
ChrisDenton
force-pushed
the
doc-extern-options
branch
from
cbc3ce7 to
c20e0e1
Compare
jyn514
approved these changes
Jun 22, 2022
|
Thanks! @bors r+ rollup |
|
📌 Commit c20e0e1 has been approved by |
bors
added
the
S-waiting-on-bors
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Jun 22, 2022
Rollup of 10 pull requests Successful merges: - rust-lang#95446 (update CPU usage script) - rust-lang#96768 (Use futex based thread parker on Fuchsia.) - rust-lang#97454 (Add release notes for 1.62) - rust-lang#97516 (clarify how Rust atomics correspond to C++ atomics) - rust-lang#97818 (Point at return expression for RPIT-related error) - rust-lang#97895 (Simplify `likely!` and `unlikely!` macro) - rust-lang#98005 (Add some tests for impossible bounds) - rust-lang#98226 (Document unstable `--extern` options) - rust-lang#98356 (Add missing period) - rust-lang#98363 (remove use of &Alloc in btree tests) Failed merges: r? `@ghost` `@rustbot` modify labels: rollup
|
@ChrisDenton |
|
I could but I'd prefer to defer to @ehuss or someone else if they have the time. I don't really know the implementation details or history. But I can do a best effort attempt if it would help get the ball rolling. |
|
I'll set up the tracking issues later today. |
|
Posted #98401 to add links to the tracking issues. |
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These are needed for Cargo's
build-stdfeature and for anyone who wanted to do a similar thing outside of Cargo.