Skip to content

Fix weird js condition #98230

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Merged
merged 1 commit into from
Jun 19, 2022
Merged

Conversation

GuillaumeGomez
Copy link
Member

While going around the code, I found this weird condition. Fixing also affects the generated results in some cases apparently (could only find this one).

Any idea maybe @notriddle?

r? @notriddle

@GuillaumeGomez GuillaumeGomez added the A-rustdoc-js Area: Rustdoc's JS front-end label Jun 18, 2022
@rust-highfive
Copy link
Contributor

Some changes occurred in HTML/CSS/JS.

cc @GuillaumeGomez,@Folyd,@jsha

@rustbot rustbot added the T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue. label Jun 18, 2022
@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Jun 18, 2022
@GuillaumeGomez
Copy link
Member Author

I simply removed the condition since it was useless. No changes in behaviour.

@notriddle
Copy link
Contributor

@bors r+ rollup

@bors
Copy link
Collaborator

bors commented Jun 18, 2022

📌 Commit 5fef77d has been approved by notriddle

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jun 18, 2022
bors added a commit to rust-lang-ci/rust that referenced this pull request Jun 19, 2022
…askrgr

Rollup of 5 pull requests

Successful merges:

 - rust-lang#97511 (Don't build the compiler before building rust-demangler)
 - rust-lang#98165 (once cell renamings)
 - rust-lang#98207 (Update cargo)
 - rust-lang#98229 (Add new eslint checks)
 - rust-lang#98230 (Fix weird js condition)

Failed merges:

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit 267fe3b into rust-lang:master Jun 19, 2022
@rustbot rustbot added this to the 1.63.0 milestone Jun 19, 2022
@GuillaumeGomez GuillaumeGomez deleted the weird-js-condition branch June 19, 2022 11:24
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
A-rustdoc-js Area: Rustdoc's JS front-end S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants