Skip to content

llvm-wrapper: adapt for LLVMConstExtractValue removal #98670

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Merged
merged 1 commit into from
Jul 1, 2022

Conversation

krasimirgg
Copy link
Contributor

@krasimirgg krasimirgg commented Jun 29, 2022

LLVMConstExtractValue was removed recently from LLVM: llvm/llvm-project@5548e80.

This adapts llvm-wrapper to use the new alternative where available, following https://rust-lang.zulipchat.com/#narrow/stream/187780-t-compiler.2Fwg-llvm/topic/LLVMConstExtractValue.20removal.

@rustbot rustbot added the T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. label Jun 29, 2022
@rust-highfive
Copy link
Contributor

r? @cuviper

(rust-highfive has picked a reviewer for you, use r? to override)

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Jun 29, 2022
@krasimirgg krasimirgg changed the title llvm-wrapper: adapt for LLVMConstExtractValue removal [NOT READY YET] llvm-wrapper: adapt for LLVMConstExtractValue removal Jun 29, 2022
@krasimirgg krasimirgg force-pushed the llvm-15-LLVMConstExtractValue branch 2 times, most recently from d9103d6 to 1c0c88c Compare June 29, 2022 13:38
@krasimirgg krasimirgg closed this Jun 29, 2022
@krasimirgg krasimirgg reopened this Jun 29, 2022
@krasimirgg krasimirgg force-pushed the llvm-15-LLVMConstExtractValue branch from 1c0c88c to f7af533 Compare June 29, 2022 14:01
@krasimirgg krasimirgg changed the title [NOT READY YET] llvm-wrapper: adapt for LLVMConstExtractValue removal llvm-wrapper: adapt for LLVMConstExtractValue removal Jun 29, 2022
@krasimirgg krasimirgg marked this pull request as ready for review June 29, 2022 15:16
@krasimirgg krasimirgg requested a review from bjorn3 June 30, 2022 06:50
@krasimirgg krasimirgg force-pushed the llvm-15-LLVMConstExtractValue branch 2 times, most recently from 2ac2fc5 to c5d3d3f Compare June 30, 2022 11:37
@bjorn3 bjorn3 removed their request for review June 30, 2022 11:39
@krasimirgg krasimirgg requested a review from nikic June 30, 2022 12:25
@krasimirgg krasimirgg force-pushed the llvm-15-LLVMConstExtractValue branch from c5d3d3f to a3a88c7 Compare June 30, 2022 12:48
@nikic
Copy link
Contributor

nikic commented Jun 30, 2022

@bors r+ rollup

@bors
Copy link
Collaborator

bors commented Jun 30, 2022

📌 Commit a3a88c7 has been approved by nikic

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jun 30, 2022
matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull request Jun 30, 2022
…Value, r=nikic

llvm-wrapper: adapt for LLVMConstExtractValue removal

`LLVMConstExtractValue` was removed recently from LLVM: llvm/llvm-project@5548e80.

This adapts llvm-wrapper to use the new alternative where available, following https://rust-lang.zulipchat.com/#narrow/stream/187780-t-compiler.2Fwg-llvm/topic/LLVMConstExtractValue.20removal.
matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull request Jun 30, 2022
…Value, r=nikic

llvm-wrapper: adapt for LLVMConstExtractValue removal

`LLVMConstExtractValue` was removed recently from LLVM: llvm/llvm-project@5548e80.

This adapts llvm-wrapper to use the new alternative where available, following https://rust-lang.zulipchat.com/#narrow/stream/187780-t-compiler.2Fwg-llvm/topic/LLVMConstExtractValue.20removal.
bors added a commit to rust-lang-ci/rust that referenced this pull request Jul 1, 2022
…askrgr

Rollup of 10 pull requests

Successful merges:

 - rust-lang#97629 ([core] add `Exclusive` to sync)
 - rust-lang#98503 (fix data race in thread::scope)
 - rust-lang#98670 (llvm-wrapper: adapt for LLVMConstExtractValue removal)
 - rust-lang#98671 (Fix source sidebar bugs)
 - rust-lang#98677 (For diagnostic information of Boolean, remind it as use the type: 'bool')
 - rust-lang#98684 (add test for 72793)
 - rust-lang#98688 (interpret: add From<&MplaceTy> for PlaceTy)
 - rust-lang#98695 (use "or pattern")
 - rust-lang#98709 (Remove unneeded methods declaration for old web browsers)
 - rust-lang#98717 (get rid of tidy 'unnecessarily ignored' warnings)

Failed merges:

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit 5cd41d7 into rust-lang:master Jul 1, 2022
@rustbot rustbot added this to the 1.64.0 milestone Jul 1, 2022
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants