promote placeholder bounds to 'static obligations #98713
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rustbot
added
the
T-compiler
rust-highfive
added
the
S-waiting-on-review
nikomatsakis
force-pushed
the
issue-98693
branch
from
878aea6 to
e604dbf
Compare
In NLL, when we are promoting a bound out from a closure, if we have a requirement that `T: 'a` where `'a` is in a higher universe, we were previously ignoring that, which is totally wrong. We should be promoting those constraints to `'static`, since universes are not expressible across closure boundaries.
nikomatsakis
force-pushed
the
issue-98693
branch
from
e604dbf to
7fda862
Compare
nikomatsakis
changed the title
|
I do somewhat worried that by explicitly "promoting" these types of bounds to @bors r+ |
bors
added
S-waiting-on-bors
|
Nominating for beta backport. Small change that fixes an unsound issue. |
jackh726
added
the
beta-nominated
matthiaskrgr
added a commit
to matthiaskrgr/rust
that referenced
this pull request
Jul 10, 2022
promote placeholder bounds to 'static obligations In NLL, when we are promoting a bound out from a closure, if we have a requirement that `T: 'a` where `'a` is in a higher universe, we were previously ignoring that, which is totally wrong. We should be promoting those constraints to `'static`, since universes are not expressible across closure boundaries. Fixes rust-lang#98693 ~~(Marking as WIP because I'm still running tests, haven't add the new test, etc)~~ r? `@jackh726`
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Jul 10, 2022
…askrgr Rollup of 5 pull requests Successful merges: - rust-lang#98713 (promote placeholder bounds to 'static obligations) - rust-lang#99094 (Remove extra space in AtomicPtr::new docs) - rust-lang#99095 (Remove duplicate notes from error on inter-crate ambiguous impl of traits) - rust-lang#99114 (Group .test-arrow CSS rules and fix rgb/rgba property) - rust-lang#99128 (Fix `download-ci-llvm` NixOS patching for binaries) Failed merges: r? `@ghost` `@rustbot` modify labels: rollup
rustbot
added
the
beta-accepted
Mark-Simulacrum
removed
the
beta-nominated
Merged
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Jul 16, 2022
…ulacrum [beta] rollup * Fix sized check ICE in asm check rust-lang#99124 * Windows: Fallback for overlapped I/O rust-lang#98950 * promote placeholder bounds to 'static obligations rust-lang#98713 * Create fresh lifetime parameters for bare fn trait too rust-lang#98637 r? `@Mark-Simulacrum`
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In NLL, when we are promoting a bound out from a closure, if we have a requirement that
T: 'awhere'ais in a higher universe, we were previously ignoring that, which is totally wrong. We should be promoting those constraints to'static, since universes are not expressible across closure boundaries.Fixes #98693
(Marking as WIP because I'm still running tests, haven't add the new test, etc)r? @jackh726