Skip to content

rustdoc: filter '_ lifetimes from ty::PolyTraitRef #98727

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 1, 2022
Merged

rustdoc: filter '_ lifetimes from ty::PolyTraitRef #98727

merged 1 commit into from
Jul 1, 2022

Conversation

notriddle
Copy link
Contributor

Fixes #98697

@rustbot rustbot added the T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue. label Jun 30, 2022
@rust-highfive
Copy link
Contributor

r? @GuillaumeGomez

(rust-highfive has picked a reviewer for you, use r? to override)

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Jun 30, 2022
@GuillaumeGomez
Copy link
Member

Thanks! r=me once CI pass

@notriddle
Copy link
Contributor Author

@bors r=GuillaumeGomez

@bors
Copy link
Collaborator

bors commented Jun 30, 2022

📌 Commit cd7bd8b has been approved by GuillaumeGomez

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jun 30, 2022
@notriddle
Copy link
Contributor Author

@bors rollup

@compiler-errors
Copy link
Member

This is a regression from stable to beta, right? If so, should we beta nominate it?

@notriddle
Copy link
Contributor Author

Yes, I think it should be beta-nominated. 👍

@notriddle
Copy link
Contributor Author

What does the rest of the team thing, though?

@rust-lang/rustdoc

matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull request Jun 30, 2022
@matthiaskrgr
Rollup merge of rust-lang#98727 - notriddle:notriddle/issue-98697, r=…
ab3d1c1 
…GuillaumeGomez

rustdoc: filter '_ lifetimes from ty::PolyTraitRef

Fixes rust-lang#98697
@matthiaskrgr matthiaskrgr mentioned this pull request Jun 30, 2022
Closed
@jsha
Copy link
Contributor

jsha commented Jun 30, 2022

I agree.

@compiler-errors compiler-errors added the beta-nominated Nominated for backporting to the compiler in the beta channel. label Jun 30, 2022
@matthiaskrgr matthiaskrgr mentioned this pull request Jul 1, 2022
Merged
bors added a commit to rust-lang-ci/rust that referenced this pull request Jul 1, 2022
@bors
Auto merge of rust-lang#98752 - matthiaskrgr:rollup-uwimznc, r=matthi…
7e2733b 
…askrgr

Rollup of 9 pull requests

Successful merges:

 - rust-lang#98610 (fix `emit_inference_failure_err` ICE)
 - rust-lang#98640 (Let rust-analyzer ship on stable, non-preview)
 - rust-lang#98686 (add ice test for 46511)
 - rust-lang#98727 (rustdoc: filter '_ lifetimes from ty::PolyTraitRef)
 - rust-lang#98729 (clarify that ExactSizeIterator::len returns the remaining length)
 - rust-lang#98733 (Request to be notified of MIR changes)
 - rust-lang#98734 (Update RELEASES.md)
 - rust-lang#98745 (Add a `--build-dir` flag to rustbuild)
 - rust-lang#98749 (Add macro_rules! rustdoc change to 1.62 relnotes)

Failed merges:

r? `@ghost`
`@rustbot` modify labels: rollup
@GuillaumeGomez
Copy link
Member

I agree as well.

@bors bors merged commit e59693a into rust-lang:master Jul 1, 2022
@rustbot rustbot added this to the 1.64.0 milestone Jul 1, 2022
@notriddle notriddle deleted the notriddle/issue-98697 branch July 1, 2022 12:57
@apiraino
Copy link
Contributor

apiraino commented Jul 7, 2022

Beta backport approved as per compiler team on Zulip

@rustbot label +beta-accepted

@rustbot rustbot added the beta-accepted Accepted for backporting to the compiler in the beta channel. label Jul 7, 2022
@Mark-Simulacrum Mark-Simulacrum modified the milestones: 1.64.0, 1.63.0 Jul 9, 2022
@Mark-Simulacrum Mark-Simulacrum removed the beta-nominated Nominated for backporting to the compiler in the beta channel. label Jul 9, 2022
@Mark-Simulacrum Mark-Simulacrum mentioned this pull request Jul 9, 2022
Merged
bors added a commit to rust-lang-ci/rust that referenced this pull request Jul 10, 2022
@bors
Auto merge of rust-lang#99098 - Mark-Simulacrum:beta-next, r=Mark-Sim…
93ef0cd 
…ulacrum

[beta] backport rollup

*  Return a FxIndexSet in is_late_bound query. rust-lang#98959
*  rustdoc: filter '_ lifetimes from ty::PolyTraitRef rust-lang#98727
* don't succeed evaluate_obligation query if new opaque types were registered rust-lang#98614
*  Update llvm-project rust-lang#98567

There's a few more as-yet-unapproved/unmerged PRs that'll land later, but creating a partial rollup for now so that we can include at least some PRs in the first crater run.

r? `@Mark-Simulacrum`
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@GuillaumeGomez GuillaumeGomez GuillaumeGomez approved these changes

Assignees

@GuillaumeGomez GuillaumeGomez

Labels
beta-accepted Accepted for backporting to the compiler in the beta channel. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
1.63.0
Development

Successfully merging this pull request may close these issues.

Rustdoc shows broken anonymous lifetimes on re-exported signatures
9 participants
@notriddle @rust-highfive @GuillaumeGomez @bors @compiler-errors @jsha @apiraino @Mark-Simulacrum @rustbot