Skip to content

interpret: make a comment less scary #98783

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 2, 2022
Merged

interpret: make a comment less scary #98783

merged 1 commit into from
Jul 2, 2022

Conversation

RalfJung
Copy link
Member

@RalfJung RalfJung commented Jul 1, 2022

This slipped past my review: "has no meaning" could be read as "is undefined behavior". That is certainly not what we mean so be more clear.

@rustbot rustbot added the T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. label Jul 1, 2022
@rustbot
Copy link
Collaborator

rustbot commented Jul 1, 2022

Some changes occurred to the CTFE / Miri engine

cc @rust-lang/miri

@rust-highfive
Copy link
Contributor

r? @fee1-dead

(rust-highfive has picked a reviewer for you, use r? to override)

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Jul 1, 2022
@fee1-dead
Copy link
Member

@bors r+ rollup

@bors
Copy link
Collaborator

bors commented Jul 2, 2022

📌 Commit 65944ce has been approved by fee1-dead

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jul 2, 2022
@Dylan-DPC Dylan-DPC mentioned this pull request Jul 2, 2022
Merged
bors added a commit to rust-lang-ci/rust that referenced this pull request Jul 2, 2022
@bors
Auto merge of rust-lang#98802 - Dylan-DPC:rollup-u6mwx27, r=Dylan-DPC
aedf78e 
Rollup of 5 pull requests

Successful merges:

 - rust-lang#98639 (Factor out `hir::Node::Binding`)
 - rust-lang#98653 (Add regression test for rust-lang#79494)
 - rust-lang#98763 (bootstrap: illumos platform flags for split-debuginfo)
 - rust-lang#98766 (cleanup mir visitor for `rustc::pass_by_value`)
 - rust-lang#98783 (interpret: make a comment less scary)

Failed merges:

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit 7a4f33b into rust-lang:master Jul 2, 2022
@rustbot rustbot added this to the 1.64.0 milestone Jul 2, 2022
@RalfJung RalfJung deleted the jumpscares branch July 2, 2022 14:13
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers
No reviews
Assignees

@fee1-dead fee1-dead

Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
1.64.0
Development

Successfully merging this pull request may close these issues.
5 participants
@RalfJung @rustbot @rust-highfive @fee1-dead @bors