Skip to content

rustdoc-json-types: Clean up derives. #98789

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Merged
merged 1 commit into from
Jul 13, 2022

Conversation

aDotInTheVoid
Copy link
Member

Closes #96189

Everything is Clone, Debug, PartialEq, Eq, Hash, Serialize, Deserialize except Crate and Item which arn't Hash, as they have HashMap's. See linked issue for reasoning.

@rustbot modify labels: +T-rustdoc +A-rustdoc-json

Closes rust-lang#96189

Closes rust-lang#96189

Everything is `Clone, Debug, PartialEq, Eq, Hash, Serialize, Deserialize`
except `Crate` and `Item` which arn't `Hash`, as they have `HashMap`'s.
See linked issue for reasoning.
@rustbot rustbot added the T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue. label Jul 1, 2022
@rust-highfive
Copy link
Contributor

r? @jsha

(rust-highfive has picked a reviewer for you, use r? to override)

@rustbot rustbot added the A-rustdoc-json Area: Rustdoc JSON backend label Jul 1, 2022
@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Jul 1, 2022
@jsha
Copy link
Contributor

jsha commented Jul 13, 2022

@bors r+ rollup

@bors
Copy link
Collaborator

bors commented Jul 13, 2022

📌 Commit 18aea45 has been approved by jsha

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jul 13, 2022
Dylan-DPC added a commit to Dylan-DPC/rust that referenced this pull request Jul 13, 2022
rustdoc-json-types: Clean up derives.

Closes rust-lang#96189

Everything is `Clone, Debug, PartialEq, Eq, Hash, Serialize, Deserialize` except `Crate` and `Item` which arn't `Hash`, as they have `HashMap`'s. See linked issue for reasoning.

`@rustbot` modify labels: +T-rustdoc +A-rustdoc-json
Dylan-DPC added a commit to Dylan-DPC/rust that referenced this pull request Jul 13, 2022
rustdoc-json-types: Clean up derives.

Closes rust-lang#96189

Everything is `Clone, Debug, PartialEq, Eq, Hash, Serialize, Deserialize` except `Crate` and `Item` which arn't `Hash`, as they have `HashMap`'s. See linked issue for reasoning.

```@rustbot``` modify labels: +T-rustdoc +A-rustdoc-json
bors added a commit to rust-lang-ci/rust that referenced this pull request Jul 13, 2022
…laumeGomez

Rollup of 10 pull requests

Successful merges:

 - rust-lang#98789 (rustdoc-json-types: Clean up derives.)
 - rust-lang#98848 (Build the Clippy book as part of x.py doc)
 - rust-lang#99020 (check non_exhaustive attr and private fields for transparent types)
 - rust-lang#99132 (Add some autolabels for A-bootstrap and T-infra)
 - rust-lang#99148 (Clarify that [iu]size bounds were only defined for the target arch)
 - rust-lang#99152 (Use CSS variables to handle theming (part 2))
 - rust-lang#99168 (Add regression test for rust-lang#74713)
 - rust-lang#99176 (:arrow_up: rust-analyzer)
 - rust-lang#99183 (Mention rust-analyzer maintainers when `proc_macro` bridge is changed)
 - rust-lang#99185 (llvm-wrapper: adapt for LLVM API change)

Failed merges:

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit 3dfb224 into rust-lang:master Jul 13, 2022
@rustbot rustbot added this to the 1.64.0 milestone Jul 13, 2022
aDotInTheVoid added a commit to rust-lang/rustdoc-types that referenced this pull request Jul 18, 2022
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
A-rustdoc-json Area: Rustdoc JSON backend S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

rustdoc-json-types: Inconsitant #[derive(s
5 participants