clean up the borrowing in rustc_hir_pretty #98854
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
a lot of the `&`s and `ref`s were redundant
rustbot
added
the
T-compiler
|
r? @oli-obk (rust-highfive has picked a reviewer for you, use r? to override) |
rustbot
added
the
C-cleanup
rust-highfive
added
the
S-waiting-on-review
|
@bors r+ |
|
📌 Commit 46ccde4 has been approved by |
bors
added
S-waiting-on-bors
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Jul 5, 2022
Rollup of 6 pull requests Successful merges: - rust-lang#97300 (Implement `FusedIterator` for `std::net::[Into]Incoming`) - rust-lang#98761 (more `need_type_info` improvements) - rust-lang#98811 (Interpret: AllocRange Debug impl, and use it more consistently) - rust-lang#98847 (fix interpreter validity check on Box) - rust-lang#98854 (clean up the borrowing in rustc_hir_pretty) - rust-lang#98873 (Suggest `#[derive(Default)]` to enums with `#[default]`) Failed merges: r? `@ghost` `@rustbot` modify labels: rollup
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A whole lot of the
&s andrefs were redundant. I hope doing this in one big commit is fine, because all of the changes are pretty self-contained.@rustbot label: +C-cleanup