add BorrowedBuf::buf* accessor functions for getting the original buffer

[programmerjake]

I noticed these functions were missing so I had to use an annoying workaround...

ACP: rust-lang/libs-team#65 [accepted]

[rustbot]

Hey! It looks like you've submitted a new PR for the library teams!

If this PR contains changes to any rust-lang/rust public library APIs then please comment with @rustbot label +T-libs-api -T-libs to tag it appropriately. If this PR contains changes to any unstable APIs please edit the PR description to add a link to the relevant API Change Proposal or create one if you haven't already. If you're unsure where your change falls no worries, just leave it as is and the reviewer will take a look and make a decision to forward on if necessary.

Examples of T-libs-api changes:

• Stabilizing library features
• Introducing insta-stable changes such as new implementations of existing stable traits on existing stable types
• Introducing new or changing existing unstable library APIs (excluding permanently unstable features / features without a tracking issue)
• Changing public documentation in ways that create new stability guarantees
• Changing observable runtime behavior of library APIs

[rust-highfive]

r? @joshtriplett

(rust-highfive has picked a reviewer for you, use r? to override)

[5225225]

buf_mut looks unsound, as you can deinitialize bytes that are assume to be init.

buf and into_buf would be fine, as would buf_mut but being unsafe (or resetting the initialized part to 0).

[programmerjake]

buf_mut looks unsound, as you can deinitialize bytes that are assume to be init.

nice catch, i changed buf_mut to be unsafe

[programmerjake]

@rustbot label +T-libs-api -T-libs

[pitaj]

Hi, this is an API change and so needs to go through the ACP process, as described by the bot. Please open one if you haven't already, and link it here.

@rustbot label -S-waiting-on-review +S-waiting-on-ACP

[programmerjake]

Hi, this is an API change and so needs to go through the ACP process, as described by the bot. Please open one if you haven't already, and link it here.

rust-lang/libs-team#65

[dtolnay]

Could you look into rebasing this past #97015?

Would these methods be needed only on BorrowedBuf, or also on BorrowedCursor?

[bors]

☔ The latest upstream changes (presumably #117736) made this pull request unmergeable. Please resolve the merge conflicts.

[dtolnay]

Let's pick this up in rust-lang/libs-team#65, or a new ACP, if there is still a use case for this.

Thanks anyway for the PR!