Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

update Miri #99034

Merged
merged 2 commits into from
Jul 8, 2022
Merged

update Miri #99034

merged 2 commits into from
Jul 8, 2022

Conversation

RalfJung
Copy link
Member

@RalfJung RalfJung commented Jul 8, 2022

Fixes #98922
r? @ghost

@rustbot
Copy link
Collaborator

rustbot commented Jul 8, 2022

The Miri submodule was changed

cc @rust-lang/miri

@RalfJung
Copy link
Member Author

RalfJung commented Jul 8, 2022

@bors r+ p=1

@bors
Copy link
Collaborator

bors commented Jul 8, 2022

📌 Commit 9fe6c19 has been approved by RalfJung

It is now in the queue for this repository.

@bors bors added the S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. label Jul 8, 2022
@rust-log-analyzer

This comment has been minimized.

# to view
@bors
Copy link
Collaborator

bors commented Jul 8, 2022

⌛ Testing commit 9fe6c19 with merge f34727583ae488c05f6ad22a32f20e67ad528929...

@rust-log-analyzer

This comment has been minimized.

# to view
@bors
Copy link
Collaborator

bors commented Jul 8, 2022

💔 Test failed - checks-actions

@bors bors added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Jul 8, 2022
@RalfJung
Copy link
Member Author

RalfJung commented Jul 8, 2022

Oh, that's an interesting error. I hope that 2nd commit makes sense...?
r? @oli-obk

@Mark-Simulacrum
Copy link
Member

Yes, this looks like the right fix to me.

@bors r+ rollup=never

@bors
Copy link
Collaborator

bors commented Jul 8, 2022

📌 Commit 1cc7139 has been approved by Mark-Simulacrum

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jul 8, 2022
@bors
Copy link
Collaborator

bors commented Jul 8, 2022

⌛ Testing commit 1cc7139 with merge 06754d8...

@bors
Copy link
Collaborator

bors commented Jul 8, 2022

☀️ Test successful - checks-actions
Approved by: Mark-Simulacrum
Pushing 06754d8 to master...

@bors bors added the merged-by-bors This PR was explicitly merged by bors. label Jul 8, 2022
@bors bors merged commit 06754d8 into rust-lang:master Jul 8, 2022
@rustbot rustbot added this to the 1.64.0 milestone Jul 8, 2022
@rust-highfive
Copy link
Contributor

📣 Toolstate changed by #99034!

Tested on commit 06754d8.
Direct link to PR: #99034

🎉 miri on windows: build-fail → test-pass (cc @oli-obk @RalfJung).
🎉 miri on linux: build-fail → test-pass (cc @oli-obk @RalfJung).

rust-highfive added a commit to rust-lang-nursery/rust-toolstate that referenced this pull request Jul 8, 2022
@rust-highfive
📣 Toolstate changed by rust-lang/rust#99034!
2119f21 
Tested on commit rust-lang/rust@06754d8.
Direct link to PR: <rust-lang/rust#99034>

🎉 miri on windows: build-fail → test-pass (cc @oli-obk @RalfJung).
🎉 miri on linux: build-fail → test-pass (cc @oli-obk @RalfJung).
@rust-timer
Copy link
Collaborator

Finished benchmarking commit (06754d8): comparison url.

Instruction count

  • Primary benchmarks: no relevant changes found
  • Secondary benchmarks: 🎉 relevant improvements found
mean1 max count2
Regressions 😿
(primary)		 N/A N/A 0
Regressions 😿
(secondary)		 N/A N/A 0
Improvements 🎉
(primary)		 N/A N/A 0
Improvements 🎉
(secondary)		 -1.3% -1.3% 4
All 😿🎉 (primary) N/A N/A 0

Max RSS (memory usage)

Results
  • Primary benchmarks: 😿 relevant regression found
  • Secondary benchmarks: 😿 relevant regression found
mean1 max count2
Regressions 😿
(primary)		 5.7% 5.7% 1
Regressions 😿
(secondary)		 3.2% 3.2% 1
Improvements 🎉
(primary)		 N/A N/A 0
Improvements 🎉
(secondary)		 N/A N/A 0
All 😿🎉 (primary) 5.7% 5.7% 1

Cycles

Results
  • Primary benchmarks: 😿 relevant regression found
  • Secondary benchmarks: 😿 relevant regressions found
mean1 max count2
Regressions 😿
(primary)		 3.0% 3.0% 1
Regressions 😿
(secondary)		 2.7% 2.7% 2
Improvements 🎉
(primary)		 N/A N/A 0
Improvements 🎉
(secondary)		 N/A N/A 0
All 😿🎉 (primary) 3.0% 3.0% 1

If you disagree with this performance assessment, please file an issue in rust-lang/rustc-perf.

@rustbot label: -perf-regression

Footnotes

  1. the arithmetic mean of the percent change ↩ ↩2 ↩3

  2. number of relevant changes ↩ ↩2 ↩3

@RalfJung RalfJung deleted the miri branch July 9, 2022 13:22
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers
No reviews
Assignees

@Mark-Simulacrum Mark-Simulacrum

Labels
merged-by-bors This PR was explicitly merged by bors. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Milestone
1.64.0
Development

Successfully merging this pull request may close these issues.

miri no longer builds after rust-lang/rust#98910
8 participants
@RalfJung @rustbot @bors @rust-log-analyzer @Mark-Simulacrum @rust-highfive @rust-timer @oli-obk