Skip to content

Add #[must_use] to Box::from_raw #99270

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 16, 2022
Merged

Add #[must_use] to Box::from_raw #99270

merged 1 commit into from
Jul 16, 2022

Conversation

rhysd
Copy link
Contributor

@rhysd rhysd commented Jul 15, 2022

Fixes #99269

@rustbot rustbot added T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. T-libs Relevant to the library team, which will review and decide on the PR/issue. labels Jul 15, 2022
@rustbot
Copy link
Collaborator

rustbot commented Jul 15, 2022

Hey! It looks like you've submitted a new PR for the library teams!

If this PR contains changes to any rust-lang/rust public library APIs then please comment with @rustbot label +T-libs-api -T-libs to tag it appropriately. If this PR contains changes to any unstable APIs please edit the PR description to add a link to the relevant API Change Proposal or create one if you haven't already. If you're unsure where your change falls no worries, just leave it as is and the reviewer will take a look and make a decision to forward on if necessary.

Examples of T-libs-api changes:

  • Stabilizing library features
  • Introducing insta-stable changes such as new implementations of existing stable traits on existing stable types
  • Introducing new or changing existing unstable library APIs (excluding permanently unstable features / features without a tracking issue)
  • Changing public documentation in ways that create new stability guarantees
  • Changing observable runtime behavior of library APIs

@rust-highfive
Copy link
Contributor

r? @Mark-Simulacrum

(rust-highfive has picked a reviewer for you, use r? to override)

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Jul 15, 2022
@rhysd
Copy link
Contributor Author

rhysd commented Jul 15, 2022

@rustbot label +T-libs-api -T-libs

@rustbot rustbot added T-libs-api Relevant to the library API team, which will review and decide on the PR/issue. and removed T-libs Relevant to the library team, which will review and decide on the PR/issue. labels Jul 15, 2022
@Mark-Simulacrum
Copy link
Member

@bors r+ rollup

I think this makes sense, and follows the pattern with CString.

@bors
Copy link
Collaborator

bors commented Jul 15, 2022

📌 Commit fa3156e has been approved by Mark-Simulacrum

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jul 15, 2022
JohnTitor added a commit to JohnTitor/rust that referenced this pull request Jul 16, 2022
@JohnTitor
Rollup merge of rust-lang#99270 - rhysd:issue-99269, r=Mark-Simulacrum
8ec29c7 
Add `#[must_use]` to `Box::from_raw`

Fixes rust-lang#99269
@JohnTitor JohnTitor mentioned this pull request Jul 16, 2022
Closed
@JohnTitor JohnTitor mentioned this pull request Jul 16, 2022
Merged
bors added a commit to rust-lang-ci/rust that referenced this pull request Jul 16, 2022
@bors
Auto merge of rust-lang#99315 - JohnTitor:rollup-77wzoc1, r=JohnTitor
7210e46 
Rollup of 7 pull requests

Successful merges:

 - rust-lang#98387 (Add new unstable API `downcast` to `std::io::Error`)
 - rust-lang#98662 (Add std::fs::write documentation precision)
 - rust-lang#99253 (Remove FIXME from MIR `always_storage_live_locals`)
 - rust-lang#99264 (Fix typo in mod.rs)
 - rust-lang#99270 (Add `#[must_use]` to `Box::from_raw`)
 - rust-lang#99277 (Stabilize `core::ffi::CStr`, `alloc::ffi::CString`, and friends)
 - rust-lang#99307 (Add regression test for rust-lang#64401)

Failed merges:

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit 96474a7 into rust-lang:master Jul 16, 2022
@rustbot rustbot added this to the 1.64.0 milestone Jul 16, 2022
@ehuss ehuss mentioned this pull request Jul 18, 2022
Merged
@multimeric multimeric mentioned this pull request Sep 23, 2022
Merged
libguestfs pushed a commit to libguestfs/nbdkit that referenced this pull request Sep 29, 2022
@rwmjones
rust: Drop box ptr
6836e4c 
Because of this recent change to rust, our close function warned that
we calculate Box::from_raw but never use it.  I added the suggested
call to drop() around the function.

rust-lang/rust#99270
libguestfs pushed a commit to libguestfs/nbdkit that referenced this pull request Oct 14, 2022
@rwmjones
rust: Drop box ptr
b3c721c 
Because of this recent change to rust, our close function warned that
we calculate Box::from_raw but never use it.  I added the suggested
call to drop() around the function.

rust-lang/rust#99270
(cherry picked from commit 6836e4c)
libguestfs pushed a commit to libguestfs/nbdkit that referenced this pull request Oct 14, 2022
@rwmjones
rust: Drop box ptr
a93f06c 
Because of this recent change to rust, our close function warned that
we calculate Box::from_raw but never use it.  I added the suggested
call to drop() around the function.

rust-lang/rust#99270
(cherry picked from commit 6836e4c)
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers
No reviews
Assignees

@Mark-Simulacrum Mark-Simulacrum

Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. T-libs-api Relevant to the library API team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
1.64.0
Development

Successfully merging this pull request may close these issues.

Ignoring return value from Box::from_raw does not cause warning
5 participants
@rhysd @rustbot @rust-highfive @Mark-Simulacrum @bors