Skip to content

Erase regions before comparing signatures of foreign fns. #99433

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Merged
merged 1 commit into from
Jul 20, 2022

Conversation

cjgillot
Copy link
Contributor

Fixes #99276

The version with explicit lifetimes is probably tracked in another bug, but I could not find it.

@rustbot rustbot added the T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. label Jul 18, 2022
@rust-highfive
Copy link
Contributor

r? @michaelwoerister

(rust-highfive has picked a reviewer for you, use r? to override)

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Jul 18, 2022
@cjgillot cjgillot force-pushed the erase-foreign-sig branch from 8a824e6 to 0065929 Compare July 19, 2022 17:36
Copy link
Member

@compiler-errors compiler-errors left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @cjgillot

@compiler-errors
Copy link
Member

@bors r+

@bors
Copy link
Collaborator

bors commented Jul 19, 2022

📌 Commit 0065929 has been approved by compiler-errors

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jul 19, 2022
bors added a commit to rust-lang-ci/rust that referenced this pull request Jul 20, 2022
Rollup of 5 pull requests

Successful merges:

 - rust-lang#98784 (Suggest returning local on "expected `ty`, found `()`" due to expr-less block)
 - rust-lang#98916 (Windows: Use `FindFirstFileW` for getting the metadata of locked system files)
 - rust-lang#99433 (Erase regions before comparing signatures of foreign fns.)
 - rust-lang#99452 (int_macros was only using to_xe_bytes_doc and not from_xe_bytes_doc)
 - rust-lang#99481 (Add regression test for rust-lang#71547)

Failed merges:

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit f02bbbc into rust-lang:master Jul 20, 2022
@rustbot rustbot added this to the 1.64.0 milestone Jul 20, 2022
@cjgillot cjgillot deleted the erase-foreign-sig branch July 20, 2022 14:34
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Regression when compiling with 07-14 nightly
6 participants