Skip to content

flag '-l link-arg=___ was added #99467

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 29, 2022
Merged

flag '-l link-arg=___ was added #99467

merged 1 commit into from
Jul 29, 2022

Conversation

belovdv
Copy link
Contributor

@belovdv belovdv commented Jul 19, 2022

@rustbot rustbot added the T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. label Jul 19, 2022
@rust-highfive
Copy link
Contributor

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @oli-obk (or someone else) soon.

Please see the contribution instructions for more information.

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Jul 19, 2022
@oli-obk
Copy link
Contributor

oli-obk commented Jul 19, 2022

r? @petrochenkov

petrochenkov
petrochenkov reviewed Jul 19, 2022
View reviewed changes
@petrochenkov petrochenkov added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jul 19, 2022
@belovdv belovdv force-pushed the add_option_link_arg branch from 6e44cc1 to 44defb5 Compare July 20, 2022 12:42
petrochenkov
petrochenkov reviewed Jul 20, 2022
View reviewed changes
@belovdv belovdv force-pushed the add_option_link_arg branch from 44defb5 to 83e9b5a Compare July 20, 2022 15:17
petrochenkov
petrochenkov reviewed Jul 20, 2022
View reviewed changes
@petrochenkov
Copy link
Contributor

Could you also squash commits into one after addressing the remaining comments?

@petrochenkov petrochenkov mentioned this pull request Jul 20, 2022
Open
3 tasks
@belovdv belovdv force-pushed the add_option_link_arg branch from 426a337 to f4816de Compare July 21, 2022 11:32
@petrochenkov
Copy link
Contributor

@bors r+

@bors
Copy link
Collaborator

bors commented Jul 21, 2022

📌 Commit f4816de has been approved by petrochenkov

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Jul 21, 2022
GuillaumeGomez added a commit to GuillaumeGomez/rust that referenced this pull request Jul 23, 2022
@GuillaumeGomez
Rollup merge of rust-lang#99467 - BelovDV:add_option_link_arg, r=petr…
0e87df4 
…ochenkov

flag '-l link-arg=___ was added

rust-lang#99427
@GuillaumeGomez GuillaumeGomez mentioned this pull request Jul 23, 2022
Closed
@GuillaumeGomez
Copy link
Member

I think this is the one which failed in #99649.

@bors r-

@bors bors added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Jul 23, 2022
@rustbot rustbot added the T-infra Relevant to the infrastructure team, which will review and decide on the PR/issue. label Jul 25, 2022
@belovdv
Lib kind -l link-arg:
7d4a98e 
arbitrary link argument like -C link-arg, but respecting relative order to other `-l` options, unstable
@belovdv belovdv force-pushed the add_option_link_arg branch from 12d09c9 to 7d4a98e Compare July 26, 2022 11:03
@petrochenkov
Copy link
Contributor

@bors r+

@bors
Copy link
Collaborator

bors commented Jul 26, 2022

📌 Commit 7d4a98e has been approved by petrochenkov

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Jul 26, 2022
@petrochenkov petrochenkov mentioned this pull request Jul 27, 2022
Closed
GuillaumeGomez added a commit to GuillaumeGomez/rust that referenced this pull request Jul 27, 2022
@GuillaumeGomez
Rollup merge of rust-lang#99467 - BelovDV:add_option_link_arg, r=petr…
be06049 
…ochenkov

flag '-l link-arg=___ was added

rust-lang#99427
@GuillaumeGomez GuillaumeGomez mentioned this pull request Jul 27, 2022
Closed
@Dylan-DPC
Copy link
Member

@bors p=1 (been in the queue for a few days now)

@bors
Copy link
Collaborator

bors commented Jul 29, 2022

⌛ Testing commit 7d4a98e with merge 5dda74a...

@bors
Copy link
Collaborator

bors commented Jul 29, 2022

☀️ Test successful - checks-actions
Approved by: petrochenkov
Pushing 5dda74a to master...

@bors bors added the merged-by-bors This PR was explicitly merged by bors. label Jul 29, 2022
@bors bors merged commit 5dda74a into rust-lang:master Jul 29, 2022
@rustbot rustbot added this to the 1.64.0 milestone Jul 29, 2022
@rust-timer
Copy link
Collaborator

Finished benchmarking commit (5dda74a): comparison url.

Instruction count

This benchmark run did not return any relevant results for this metric.

Max RSS (memory usage)

Results
  • Primary benchmarks: mixed results
  • Secondary benchmarks: 😿 relevant regressions found
mean1 max count2
Regressions 😿
(primary)		 3.3% 3.3% 1
Regressions 😿
(secondary)		 2.7% 2.9% 2
Improvements 🎉
(primary)		 -1.7% -2.4% 2
Improvements 🎉
(secondary)		 N/A N/A 0
All 😿🎉 (primary) -0.0% 3.3% 3

Cycles

Results
  • Primary benchmarks: 🎉 relevant improvement found
  • Secondary benchmarks: 😿 relevant regression found
mean1 max count2
Regressions 😿
(primary)		 N/A N/A 0
Regressions 😿
(secondary)		 4.4% 4.4% 1
Improvements 🎉
(primary)		 -2.1% -2.1% 1
Improvements 🎉
(secondary)		 N/A N/A 0
All 😿🎉 (primary) -2.1% -2.1% 1

If you disagree with this performance assessment, please file an issue in rust-lang/rustc-perf.

@rustbot label: -perf-regression

Footnotes

  1. the arithmetic mean of the percent change ↩ ↩2

  2. number of relevant changes ↩ ↩2

# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@petrochenkov petrochenkov petrochenkov left review comments

Assignees

@petrochenkov petrochenkov

Labels
merged-by-bors This PR was explicitly merged by bors. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. T-infra Relevant to the infrastructure team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
1.64.0
Development

Successfully merging this pull request may close these issues.
9 participants
@belovdv @rust-highfive @oli-obk @petrochenkov @bors @GuillaumeGomez @Dylan-DPC @rust-timer @rustbot