Skip to content

Fix the stable version of AsFd for Arc<T> and Box<T> #99523

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 21, 2022
Merged

Fix the stable version of AsFd for Arc<T> and Box<T> #99523

merged 1 commit into from
Jul 21, 2022

Conversation

cuviper
Copy link
Member

@cuviper cuviper commented Jul 20, 2022

These merged in #97437 for 1.64.0, apart from the main io_safety
feature that stabilized in 1.63.0.

@cuviper
Fix the stable version of AsFd for Arc<T> and Box<T>
bd0474d 
These merged in rust-lang#97437 for 1.64.0, apart from the main `io_safety`
feature that stabilized in 1.63.0.
@rustbot rustbot added the T-libs Relevant to the library team, which will review and decide on the PR/issue. label Jul 20, 2022
@rustbot
Copy link
Collaborator

rustbot commented Jul 20, 2022

Hey! It looks like you've submitted a new PR for the library teams!

If this PR contains changes to any rust-lang/rust public library APIs then please comment with @rustbot label +T-libs-api -T-libs to tag it appropriately. If this PR contains changes to any unstable APIs please edit the PR description to add a link to the relevant API Change Proposal or create one if you haven't already. If you're unsure where your change falls no worries, just leave it as is and the reviewer will take a look and make a decision to forward on if necessary.

Examples of T-libs-api changes:

  • Stabilizing library features
  • Introducing insta-stable changes such as new implementations of existing stable traits on existing stable types
  • Introducing new or changing existing unstable library APIs (excluding permanently unstable features / features without a tracking issue)
  • Changing public documentation in ways that create new stability guarantees
  • Changing observable runtime behavior of library APIs

@rust-highfive
Copy link
Contributor

r? @kennytm

(rust-highfive has picked a reviewer for you, use r? to override)

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Jul 20, 2022
@cuviper cuviper mentioned this pull request Jul 20, 2022
Merged
@jyn514
Copy link
Member

jyn514 commented Jul 20, 2022

@bors r+ rollup

@bors
Copy link
Collaborator

bors commented Jul 20, 2022

📌 Commit bd0474d has been approved by jyn514

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jul 20, 2022
matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull request Jul 20, 2022
@matthiaskrgr
Rollup merge of rust-lang#99523 - cuviper:asfd_ptrs-1.64, r=jyn514
37e62fa 
Fix the stable version of `AsFd for Arc<T>` and `Box<T>`

These merged in rust-lang#97437 for 1.64.0, apart from the main `io_safety`
feature that stabilized in 1.63.0.
@matthiaskrgr matthiaskrgr mentioned this pull request Jul 20, 2022
Closed
@Dylan-DPC Dylan-DPC mentioned this pull request Jul 21, 2022
Closed
Dylan-DPC added a commit to Dylan-DPC/rust that referenced this pull request Jul 21, 2022
@Dylan-DPC
Rollup merge of rust-lang#99523 - cuviper:asfd_ptrs-1.64, r=jyn514
af3cb7c 
Fix the stable version of `AsFd for Arc<T>` and `Box<T>`

These merged in rust-lang#97437 for 1.64.0, apart from the main `io_safety`
feature that stabilized in 1.63.0.
@Dylan-DPC Dylan-DPC mentioned this pull request Jul 21, 2022
Closed
Dylan-DPC added a commit to Dylan-DPC/rust that referenced this pull request Jul 21, 2022
@Dylan-DPC
Rollup merge of rust-lang#99523 - cuviper:asfd_ptrs-1.64, r=jyn514
3bb74ab 
Fix the stable version of `AsFd for Arc<T>` and `Box<T>`

These merged in rust-lang#97437 for 1.64.0, apart from the main `io_safety`
feature that stabilized in 1.63.0.
Dylan-DPC added a commit to Dylan-DPC/rust that referenced this pull request Jul 21, 2022
@Dylan-DPC
Rollup merge of rust-lang#99523 - cuviper:asfd_ptrs-1.64, r=jyn514
03d4902 
Fix the stable version of `AsFd for Arc<T>` and `Box<T>`

These merged in rust-lang#97437 for 1.64.0, apart from the main `io_safety`
feature that stabilized in 1.63.0.
@Dylan-DPC Dylan-DPC mentioned this pull request Jul 21, 2022
Closed
Dylan-DPC added a commit to Dylan-DPC/rust that referenced this pull request Jul 21, 2022
@Dylan-DPC
Rollup merge of rust-lang#99523 - cuviper:asfd_ptrs-1.64, r=jyn514
a45a0d6 
Fix the stable version of `AsFd for Arc<T>` and `Box<T>`

These merged in rust-lang#97437 for 1.64.0, apart from the main `io_safety`
feature that stabilized in 1.63.0.
@Dylan-DPC Dylan-DPC mentioned this pull request Jul 21, 2022
Closed
matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull request Jul 21, 2022
@matthiaskrgr
Rollup merge of rust-lang#99523 - cuviper:asfd_ptrs-1.64, r=jyn514
a9ab1d4 
Fix the stable version of `AsFd for Arc<T>` and `Box<T>`

These merged in rust-lang#97437 for 1.64.0, apart from the main `io_safety`
feature that stabilized in 1.63.0.
@matthiaskrgr matthiaskrgr mentioned this pull request Jul 21, 2022
Closed
@matthiaskrgr matthiaskrgr mentioned this pull request Jul 21, 2022
Merged
Dylan-DPC added a commit to Dylan-DPC/rust that referenced this pull request Jul 21, 2022
@Dylan-DPC
Rollup merge of rust-lang#99523 - cuviper:asfd_ptrs-1.64, r=jyn514
d164d06 
Fix the stable version of `AsFd for Arc<T>` and `Box<T>`

These merged in rust-lang#97437 for 1.64.0, apart from the main `io_safety`
feature that stabilized in 1.63.0.
@Dylan-DPC Dylan-DPC mentioned this pull request Jul 21, 2022
Closed
bors added a commit to rust-lang-ci/rust that referenced this pull request Jul 21, 2022
@bors
Auto merge of rust-lang#99567 - matthiaskrgr:rollup-08hh3r4, r=matthi…
af7ab34 
…askrgr

Rollup of 11 pull requests

Successful merges:

 - rust-lang#98707 (std: use futex-based locks on Fuchsia)
 - rust-lang#99413 (Add `PhantomData` marker for dropck to `BTreeMap`)
 - rust-lang#99454 (Add map_continue and continue_value combinators to ControlFlow)
 - rust-lang#99523 (Fix the stable version of `AsFd for Arc<T>` and `Box<T>`)
 - rust-lang#99526 (Normalize the arg spans to be within the call span)
 - rust-lang#99528 (couple of clippy::perf fixes)
 - rust-lang#99549 (Add regression test for rust-lang#52304)
 - rust-lang#99552 (Rewrite `orphan_check_trait_ref` to use a `TypeVisitor`)
 - rust-lang#99557 (Edit `rustc_index::vec::IndexVec::pick3_mut` docs)
 - rust-lang#99558 (Fix `remap_constness`)
 - rust-lang#99559 (Remove unused field in ItemKind::KeywordItem)

Failed merges:

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit 84a7b23 into rust-lang:master Jul 21, 2022
@rustbot rustbot added this to the 1.64.0 milestone Jul 21, 2022
@jplatte
Copy link
Contributor

jplatte commented Jul 25, 2022 •
edited
Loading

I thought trait implementations can't be unstable when the trait itself is stable?

Nevermind, these were new impls, not stabilized separately from being added.

@cuviper cuviper deleted the asfd_ptrs-1.64 branch October 15, 2022 00:15
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers
No reviews
Assignees

@kennytm kennytm

Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-libs Relevant to the library team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
1.64.0
Development

Successfully merging this pull request may close these issues.
7 participants
@cuviper @rustbot @rust-highfive @jyn514 @bors @jplatte @kennytm