Add sign-ext target feature to the WASM target
#99643
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rustbot
added
the
T-compiler
|
r? @oli-obk (rust-highfive has picked a reviewer for you, use r? to override) |
rust-highfive
added
the
S-waiting-on-review
|
@bors r+ |
bors
added
S-waiting-on-bors
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Jul 25, 2022
Rollup of 7 pull requests Successful merges: - rust-lang#95040 (protect `std::io::Take::limit` from overflow in `read`) - rust-lang#95916 (kmc-solid: Use `libc::abort` to abort a program) - rust-lang#99494 (Use non-relocatable code in nofile-limit.rs test) - rust-lang#99581 (Improve error messages involving `derive` and `packed`.) - rust-lang#99643 (Add `sign-ext` target feature to the WASM target) - rust-lang#99659 (Use `VecMap::get` in `ConstraintLocator::check`) - rust-lang#99690 (add miri-track-caller to more intrinsic-exposing methods) Failed merges: r? `@ghost` `@rustbot` modify labels: rollup
Manishearth
added a commit
to Manishearth/rust
that referenced
this pull request
Nov 2, 2022
Add `multivalue` target feature to WASM target This PR is similar to rust-lang#99643 and rust-lang#97808. It addresses rust-lang#96472 for the `multivalue` target feature. The problem I am trying to fix is to remove the following warning when compiling with `-C target-feature=+multivalue` for `--target=wasm32-unknown-unknown`. ``` warning: unknown feature specified for `-Ctarget-feature`: `multivalue` | = note: it is still passed through to the codegen backend = note: consider filing a feature request ```
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some target features are still missing from that list.
See #97808 for basically the same PR by @alexcrichton.
Related issue: #96472.
PR introducing this issue: #87402.