Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Add a clickable link to the layout section #99700

Merged
merged 2 commits into from
Jul 27, 2022

Conversation

est31
Copy link
Member

@est31 est31 commented Jul 24, 2022

The layout section (activated by --show-type-layout) is currently not linkable to (outside of chrome's link to text feature). This PR makes it linkable via #layout.

@rustbot rustbot added the T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue. label Jul 24, 2022
@rust-highfive
Copy link
Collaborator

r? @GuillaumeGomez

(rust-highfive has picked a reviewer for you, use r? to override)

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Jul 24, 2022
@est31 est31 marked this pull request as ready for review July 24, 2022 22:38
@GuillaumeGomez
Copy link
Member

Please add a test in src/test/rustdoc for this please.

@est31 est31 force-pushed the rustdoc_layout_heading branch from 1b33257 to 5fcd2f7 Compare July 25, 2022 17:11
Co-authored-by: Guillaume Gomez <guillaume1.gomez@gmail.com>
@GuillaumeGomez
Copy link
Member

Thanks! r=me once CI pass.

@est31
Copy link
Member Author

est31 commented Jul 26, 2022

They do! Please r+ :)

@GuillaumeGomez
Copy link
Member

I thought you had r+ rights. My bad.

@bors r+ rollup

@bors
Copy link
Contributor

bors commented Jul 26, 2022

📌 Commit 15db418 has been approved by GuillaumeGomez

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jul 26, 2022
matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull request Jul 26, 2022
…llaumeGomez

Add a clickable link to the layout section

The layout section (activated by `--show-type-layout`) is currently not linkable to (outside of chrome's link to text feature). This PR makes it linkable via `#layout`.
bors added a commit to rust-lang-ci/rust that referenced this pull request Jul 27, 2022
Rollup of 8 pull requests

Successful merges:

 - rust-lang#98583 (Stabilize Windows `FileTypeExt` with `is_symlink_dir` and `is_symlink_file`)
 - rust-lang#99698 (Prefer visibility map parents that are not `doc(hidden)` first)
 - rust-lang#99700 (Add a clickable link to the layout section)
 - rust-lang#99712 (passes: port more of `check_attr` module)
 - rust-lang#99759 (Remove dead code from cg_llvm)
 - rust-lang#99765 (Don't build std for *-uefi targets)
 - rust-lang#99771 (Update pulldown-cmark version to 0.9.2 (fixes url encoding for some chars))
 - rust-lang#99775 (rustdoc: do not allocate String when writing path full name)

Failed merges:

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit 181bf05 into rust-lang:master Jul 27, 2022
@rustbot rustbot added this to the 1.64.0 milestone Jul 27, 2022
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants