Skip to content

Fix futex module imports on wasm+atomics #99800

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 3, 2022
Merged

Fix futex module imports on wasm+atomics #99800

merged 1 commit into from
Aug 3, 2022

Conversation

sandydoo
Copy link
Contributor

The futex modules were rearranged a bit in #98707, which meant that wasm+atomics would no longer compile on nightly. I don’t believe any other targets were impacted by this.

@rustbot rustbot added the T-libs Relevant to the library team, which will review and decide on the PR/issue. label Jul 27, 2022
@rustbot
Copy link
Collaborator

rustbot commented Jul 27, 2022

Hey! It looks like you've submitted a new PR for the library teams!

If this PR contains changes to any rust-lang/rust public library APIs then please comment with @rustbot label +T-libs-api -T-libs to tag it appropriately. If this PR contains changes to any unstable APIs please edit the PR description to add a link to the relevant API Change Proposal or create one if you haven't already. If you're unsure where your change falls no worries, just leave it as is and the reviewer will take a look and make a decision to forward on if necessary.

Examples of T-libs-api changes:

  • Stabilizing library features
  • Introducing insta-stable changes such as new implementations of existing stable traits on existing stable types
  • Introducing new or changing existing unstable library APIs (excluding permanently unstable features / features without a tracking issue)
  • Changing public documentation in ways that create new stability guarantees
  • Changing observable runtime behavior of library APIs

@rust-highfive
Copy link
Contributor

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @joshtriplett (or someone else) soon.

Please see the contribution instructions for more information.

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Jul 27, 2022
@sandydoo
Copy link
Contributor Author

r? @m-ou-se

@Desdaemon Desdaemon mentioned this pull request Aug 1, 2022
Merged
3 tasks
@fzyzcjy
Copy link

fzyzcjy commented Aug 1, 2022

Hi, thanks for the PR, is there any updates? This is a must for https://github.com/fzyzcjy/flutter_rust_bridge to support web...

@sandydoo sandydoo mentioned this pull request Aug 3, 2022
Closed
@m-ou-se
Copy link
Member

m-ou-se commented Aug 3, 2022

@bors r+

@bors
Copy link
Collaborator

bors commented Aug 3, 2022

📌 Commit e3afce8 has been approved by m-ou-se

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Aug 3, 2022
@Dylan-DPC Dylan-DPC mentioned this pull request Aug 3, 2022
Merged
bors added a commit to rust-lang-ci/rust that referenced this pull request Aug 3, 2022
@bors
Auto merge of rust-lang#100100 - Dylan-DPC:rollup-llcaaq8, r=Dylan-DPC
7308c22 
Rollup of 5 pull requests

Successful merges:

 - rust-lang#99371 (Remove synchronization from Windows `hashmap_random_keys`)
 - rust-lang#99614 (do not claim that transmute is like memcpy)
 - rust-lang#99738 (rustdoc: avoid inlining modules with duplicate names)
 - rust-lang#99800 (Fix futex module imports on wasm+atomics)
 - rust-lang#100079 (Replace `* -> vec` with `-> vec` in docs)

Failed merges:

r? `@ghost`
`@rustbot` modify labels: rollup
@ghost ghost mentioned this pull request Aug 3, 2022
Closed
@bors bors merged commit 8d465cc into rust-lang:master Aug 3, 2022
@rustbot rustbot added this to the 1.64.0 milestone Aug 3, 2022
@joboet joboet mentioned this pull request Nov 12, 2022
Closed
@joboet joboet mentioned this pull request Apr 21, 2023
Closed
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers
No reviews
Assignees

@m-ou-se m-ou-se

Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-libs Relevant to the library team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
1.64.0
Development

Successfully merging this pull request may close these issues.
7 participants
@sandydoo @rustbot @rust-highfive @fzyzcjy @m-ou-se @bors @joshtriplett