Skip to content

fix ICE when computing codegen_fn_attrs on closure with non-fn parent #99881

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 30, 2022
Merged

fix ICE when computing codegen_fn_attrs on closure with non-fn parent #99881

merged 1 commit into from
Jul 30, 2022

Conversation

compiler-errors
Copy link
Member

Other call sites check has_codegen_attrs first, so let's do that too.

Fixes #99876

@rustbot rustbot added the T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. label Jul 29, 2022
@rust-highfive
Copy link
Contributor

r? @cjgillot

(rust-highfive has picked a reviewer for you, use r? to override)

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Jul 29, 2022
@tmiasko
Copy link
Contributor

tmiasko commented Jul 29, 2022

@bors r+

@bors
Copy link
Collaborator

bors commented Jul 29, 2022

📌 Commit b67ba9b has been approved by tmiasko

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jul 29, 2022
@JohnTitor JohnTitor mentioned this pull request Jul 29, 2022
Merged
bors added a commit to rust-lang-ci/rust that referenced this pull request Jul 30, 2022
@bors
Auto merge of rust-lang#99925 - JohnTitor:rollup-4bt9ou3, r=JohnTitor
8f68c43 
Rollup of 8 pull requests

Successful merges:

 - rust-lang#99227 (Fix thumbv4t-none-eabi frame pointer setting)
 - rust-lang#99518 (Let-else: break out scopes when a let-else pattern fails to match)
 - rust-lang#99671 (Suggest dereferencing index when trying to use a reference of usize as index)
 - rust-lang#99831 (Add Fuchsia platform support documentation)
 - rust-lang#99881 (fix ICE when computing codegen_fn_attrs on closure with non-fn parent)
 - rust-lang#99888 (Streamline lint checking)
 - rust-lang#99891 (Adjust an expr span to account for macros)
 - rust-lang#99904 (Cleanup html whitespace)

Failed merges:

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit c1a5c11 into rust-lang:master Jul 30, 2022
@rustbot rustbot added this to the 1.64.0 milestone Jul 30, 2022
@compiler-errors compiler-errors deleted the issue-99876 branch August 11, 2023 20:06
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers
No reviews
Assignees

@cjgillot cjgillot

Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
1.64.0
Development

Successfully merging this pull request may close these issues.

ICE: 'unexpected def_kind in codegen_fn_attrs: AnonConst', compiler/rustc_typeck/src/collect.rs:2695:9 with target_feature_11
6 participants
@compiler-errors @rust-highfive @tmiasko @bors @cjgillot @rustbot