Skip to content

Delay formatting trimmed path until lint/error is emitted #99893

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom
Merged
merged 2 commits into from
Aug 6, 2022
Merged

Delay formatting trimmed path until lint/error is emitted #99893

merged 2 commits into from
Aug 6, 2022

Conversation

compiler-errors
Copy link
Member

Fixes #99387

r? @davidtwco

@rustbot rustbot added the T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. label Jul 29, 2022
@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Jul 29, 2022
davidtwco
davidtwco approved these changes Jul 29, 2022
View reviewed changes
Copy link
Member

@davidtwco davidtwco left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, one or two comments then feel free to r=me

@davidtwco davidtwco added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Aug 2, 2022
@matthiaskrgr matthiaskrgr mentioned this pull request Aug 3, 2022
Closed
@compiler-errors
Copy link
Member Author

@bors r=davidtwco

@bors
Copy link
Collaborator

bors commented Aug 5, 2022

📌 Commit 694a010 has been approved by davidtwco

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Aug 5, 2022
@ChunMinChang ChunMinChang mentioned this pull request Aug 5, 2022
Merged
@bors
Copy link
Collaborator

bors commented Aug 6, 2022

⌛ Testing commit 694a010 with merge 76b0484...

@bors
Copy link
Collaborator

bors commented Aug 6, 2022

☀️ Test successful - checks-actions
Approved by: davidtwco
Pushing 76b0484 to master...

@bors bors added the merged-by-bors This PR was explicitly merged by bors. label Aug 6, 2022
@bors bors merged commit 76b0484 into rust-lang:master Aug 6, 2022
@rustbot rustbot added this to the 1.65.0 milestone Aug 6, 2022
@rust-timer
Copy link
Collaborator

Finished benchmarking commit (76b0484): comparison url.

Instruction count

This benchmark run did not return any relevant results for this metric.

Max RSS (memory usage)

Results
  • Primary benchmarks: mixed results
  • Secondary benchmarks: 😿 relevant regression found
mean1 max count2
Regressions 😿
(primary)		 2.7% 2.7% 1
Regressions 😿
(secondary)		 2.8% 2.8% 1
Improvements 🎉
(primary)		 -4.4% -4.4% 1
Improvements 🎉
(secondary)		 N/A N/A 0
All 😿🎉 (primary) -0.8% -4.4% 2

Cycles

This benchmark run did not return any relevant results for this metric.

If you disagree with this performance assessment, please file an issue in rust-lang/rustc-perf.

@rustbot label: -perf-regression

Footnotes

  1. the arithmetic mean of the percent change ↩

  2. number of relevant changes ↩

@compiler-errors compiler-errors mentioned this pull request Aug 14, 2022
Closed
@ehuss ehuss mentioned this pull request Aug 30, 2022
Closed
ehuss pushed a commit to ehuss/rust that referenced this pull request Aug 31, 2022
@bors @ehuss
Auto merge of rust-lang#99893 - compiler-errors:issue-99387, r=davidtwco
b4b39cd 
Delay formatting trimmed path until lint/error is emitted

Fixes rust-lang#99387

r? `@davidtwco`
@ehuss ehuss mentioned this pull request Aug 31, 2022
Merged
@ehuss ehuss added the beta-accepted Accepted for backporting to the compiler in the beta channel. label Aug 31, 2022
@ehuss ehuss modified the milestones: 1.65.0, 1.64.0 Aug 31, 2022
bors added a commit to rust-lang-ci/rust that referenced this pull request Aug 31, 2022
@bors
Auto merge of rust-lang#101221 - ehuss:update-beta-cargo, r=ehuss
4497ac9 
[BETA] Beta 1.64 backports

* Cargo:
    * remove missed reference to workspace inheritance in unstable.md (rust-lang/cargo#11002)
* Delay formatting trimmed path until lint/error is emitted rust-lang#99893
* Use `node_type_opt` to skip over generics that were not expected rust-lang#100155
* Revert "Remove a back-compat hack on lazy TAIT rust-lang#97346" rust-lang#99860
@compiler-errors compiler-errors deleted the issue-99387 branch August 11, 2023 20:05
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@davidtwco davidtwco davidtwco approved these changes

Assignees

@davidtwco davidtwco

Labels
beta-accepted Accepted for backporting to the compiler in the beta channel. merged-by-bors This PR was explicitly merged by bors. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
1.64.0
Development

Successfully merging this pull request may close these issues.

ICE: delayed_good_path_bugs: trimmed_def_paths constructed
7 participants
@compiler-errors @bors @rust-timer @davidtwco @ehuss @rust-highfive @rustbot