Skip to content

Fix Ipv6Addr::is_unicast_global to check for unicast global scope rebase #99947

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom
Merged
merged 0 commits into from
Aug 24, 2022
Merged

Fix Ipv6Addr::is_unicast_global to check for unicast global scope rebase #99947

merged 0 commits into from
Aug 24, 2022

Conversation

chotchki
Copy link
Contributor

Rebasing of pull request #85696 off of master to try and get the feature "ip" stabilized.

@rustbot rustbot added the T-libs Relevant to the library team, which will review and decide on the PR/issue. label Jul 30, 2022
@rustbot
Copy link
Collaborator

rustbot commented Jul 30, 2022

Hey! It looks like you've submitted a new PR for the library teams!

If this PR contains changes to any rust-lang/rust public library APIs then please comment with @rustbot label +T-libs-api -T-libs to tag it appropriately. If this PR contains changes to any unstable APIs please edit the PR description to add a link to the relevant API Change Proposal or create one if you haven't already. If you're unsure where your change falls no worries, just leave it as is and the reviewer will take a look and make a decision to forward on if necessary.

Examples of T-libs-api changes:

  • Stabilizing library features
  • Introducing insta-stable changes such as new implementations of existing stable traits on existing stable types
  • Introducing new or changing existing unstable library APIs (excluding permanently unstable features / features without a tracking issue)
  • Changing public documentation in ways that create new stability guarantees
  • Changing observable runtime behavior of library APIs

@rust-highfive
Copy link
Contributor

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @m-ou-se (or someone else) soon.

Please see the contribution instructions for more information.

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Jul 30, 2022
@rust-log-analyzer

This comment has been minimized.

# to view
@chotchki
Copy link
Contributor Author

@rustbot label +T-libs-api

@rustbot rustbot added the T-libs-api Relevant to the library API team, which will review and decide on the PR/issue. label Jul 30, 2022
@chotchki chotchki mentioned this pull request Jul 30, 2022
Merged
@Mark-Simulacrum
Copy link
Member

@bors r+ rollup

This makes rough sense to me, though I'm not super familiar with this area of networking. I think given this is all unstable we can merge this in and make sure these are what we want during stabilization.

@bors
Copy link
Collaborator

bors commented Aug 21, 2022

📌 Commit 7c660b47ef98e7ad5c5fa81bbfb873d24d6c3df0 has been approved by Mark-Simulacrum

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Aug 21, 2022
@Mark-Simulacrum Mark-Simulacrum mentioned this pull request Aug 21, 2022
Closed
Dylan-DPC added a commit to Dylan-DPC/rust that referenced this pull request Aug 22, 2022
@Dylan-DPC
Rollup merge of rust-lang#99957 - chotchki:ip-globally-reachable_reba…
c1a5ec7 
…se, r=Mark-Simulacrum

Rework Ipv6Addr::is_global to check for global reachability rather than global scope - rebase

Rebasing of pull request rust-lang#86634 off of master to try and get the feature "ip" stabilized.

I also found a test failure in the rebase that is_global was considering the benchmark space to be globally reachable.

This is related to my other rebasing pull request rust-lang#99947
@bors
Copy link
Collaborator

bors commented Aug 22, 2022

☔ The latest upstream changes (presumably #100881) made this pull request unmergeable. Please resolve the merge conflicts.

@bors bors added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Aug 22, 2022
@chotchki chotchki merged commit 87991d5 into rust-lang:master Aug 24, 2022
@rustbot rustbot added this to the 1.65.0 milestone Aug 24, 2022
@chotchki
Copy link
Contributor Author

@Mark-Simulacrum I did the rebase of https://github.com/chotchki/rust/tree/unicast_global but had to recreate the branch and as a result the GitHub pull request history looks really strange to me. Should I recreate the pull request?

# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers
No reviews
Assignees

@m-ou-se m-ou-se

Labels
S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. T-libs Relevant to the library team, which will review and decide on the PR/issue. T-libs-api Relevant to the library API team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
1.65.0
Development

Successfully merging this pull request may close these issues.
7 participants
@chotchki @rustbot @rust-highfive @rust-log-analyzer @Mark-Simulacrum @bors @m-ou-se