Suggest removing a semicolon and boxing the expressions for if-else #99974
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rustbot
added
the
T-compiler
|
r? @estebank (rust-highfive has picked a reviewer for you, use r? to override) |
rust-highfive
added
the
S-waiting-on-review
|
r? @compiler-errors @bors r+ rolluo |
bors
added
S-waiting-on-bors
|
@bors rollup |
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Jul 31, 2022
Rollup of 5 pull requests Successful merges: - rust-lang#99186 (Use LocalDefId for closures more) - rust-lang#99741 (Use `impl`'s generics when suggesting fix on bad `impl Copy`) - rust-lang#99844 (Introduce an ArchiveBuilderBuilder) - rust-lang#99921 (triagebot.yml: CC Enselic when rustdoc-json-types changes) - rust-lang#99974 (Suggest removing a semicolon and boxing the expressions for if-else) Failed merges: r? `@ghost` `@rustbot` modify labels: rollup
TaKO8Ki
deleted the
suggest-removing-semicolon-and-boxing-the-expressions
branch
estebank
reviewed
Aug 1, 2022
| @@ -0,0 +1,70 @@ | |||
| // edition:2018 | |||
There was a problem hiding this comment.
This file can be // run-rustfix, right?
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
InferCtxt::suggest_remove_semi_or_return_bindingwas not working well for if-else, so I fixed it and added a ui test.